"Push to a remote repository" "Only protected branches" selector behavior is incorrect.

Summary

In mirror a repo via "Push to a remote repository", the "Only protected branches" selector behave opposite to what it should.

Steps to reproduce

• mirror a repo via "Push to a remote repository", selecting "Only protected branches" (this is the default)
• push to a non protected branch
• check the mirror, branch is updated (expected: it should not have been updated)
• go back to mirror a repo via "Push to a remote repository", unselect selecting "Only protected branches"
• push to a non protected branch
• check the mirror branch is not updated (expected: it should have been updated)

Example Project

Not a CE feature, cannot reproduce on gitlab.com

What is the current bug behavior?

Non protected branch are mirrored when "only protected branch" is selected Non protected branch are not mirrored when "only protected branch" is not selected

What is the expected correct behavior?

Non protected branch are not mirrored when "only protected branch" is selected Non protected branch are mirrored when "only protected branch" is not selected

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's very hard to read otherwise.)

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

# gitlab-rake gitlab:env:info
System information
System:
Proxy:		no
Current User:	git
Using RVM:	no
Ruby Version:	2.3.6p384
Gem Version:	2.6.13
Bundler Version:1.13.7
Rake Version:	12.3.0
Redis Version:	3.2.11
Git Version:	2.14.3
Sidekiq Version:5.0.5
Go Version:	unknown
GitLab information
Version:	10.6.4-ee
Revision:	42f072e
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	postgresql
DB Version:	9.6.5
URL:		https://gitlab.sebv.tw
HTTP Clone URL:	https://gitlab.sebv.tw/some-group/some-project.git
SSH Clone URL:	git@gitlab.sebv.tw:some-group/some-project.git
Elasticsearch:	no
Geo:		no
Using LDAP:	no
Using Omniauth:	no
GitLab Shell
Version:	6.0.4
Repository storage paths:

• default: /gitlab-data/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check

Checking GitLab Shell ...
GitLab Shell version >= 6.0.4 ? ... OK (6.0.4)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:root, or git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
2/1 ... ok
1/2 ... ok
4/3 ... ok
4/4 ... ok
1/5 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK
Access to /gitlab-data/ssh/authorized_keys: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... skipped (no tmp uploads folder yet)
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
2/1 ... yes
1/2 ... yes
4/3 ... yes
4/4 ... yes
1/5 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.5 ? ... yes (2.3.6)
Git version >= 2.9.5 ? ... yes (2.14.3)
Git user has default SSH configuration? ... yes
Active users: ... 4
Elasticsearch version 5.1 - 5.5? ... skipped (elasticsearch is disabled)
Checking GitLab ... Finished

Possible fixes