Follow-up from "Convert homepage widgets to 4-card tile layout"
The following discussions from !202520 (merged) should be addressed:
-
@kpalchyk started a discussion:
question (non-blocking, might need follow-up): should we be able to use
formatNumberfrom~/localeto do the same? I'd defer to it to read and check locale.We can do that in a follow-up.
-
@kpalchyk started a discussion:
suggestion (non-blocking, might need follow-up): since we have two places where we do this, let's define this in a common
.jsutility file, just local to the module. I.e.~/homepage/utils.jsor something like that.Though this could look even better as component:
<number-format :value="count" />I'm leaning to make it local to
~/homepage/, unless we establish a common rule for whole GitLab. Then we can seek how we could make it public. -
@kpalchyk started a discussion:
suggestion (non-blocking, might need follow-up): is there a way to make these card's HTML reusable? I'd really like not to repeat all the css classes. They seem to be very similar in presentation. Just a value, icon, and foot notes.
-
@kpalchyk started a discussion:
suggestion (for follow-up): let's get Technical Writing input on the aria-labels. Maybe we'd really need a full thing with
sprintfas in !202520 (comment 2713887884)(I'll include this in a follow-up issue)
-
@kpalchyk started a discussion
decide on a common approach on big number shortening for MRs, and maybe create a dedicated note about this in our Pajamas. See !202520 (comment 2719502152) for details