Skip to content

Submit pending review comments when using "approve"

Proposal

When a reviewer approves a merge request submit all draft comments along with the approval

Scenario

When using the quick action /approve or clicking on the "Approve" button in the approval widget, pending comments are not submitted along with that action. This results in pending comments of a review to be left in a draft state and therefore no one else can see those comments.

Approve comment with pending After approving
CleanShot_2025-07-31_at_12.54.58 CleanShot_2025-07-31_at_12.55.10

Workaround

The workaround for this is to use the review panel to submit an approval or the quick action /submit_review approve

Solution

  1. Alias the quick action /approve to /submit_review approve
  2. When clicking "Approve" button, submit pending comments along with that action.
Edited by 🤖 GitLab Bot 🤖