FE: Update MR widget for warn mode
Why are we doing this work
- The MR widget needs to show information for the warn mode policy violations
- Users should be able to dismiss warn mode policy violations
Relevant links
Non-functional requirements
-
Documentation: -
Feature flag: -
Performance: -
Testing:
Implementation plan
-
Add info icon and button to vue_merge_request_widget/components/checks/security_policy_violations.vue -
ee/app/assets/javascripts/vue_merge_request_widget/components/checks/requested_changes.vue does a modal, follow it
-
-
On click, open modal with form -
On save, mutation saves info and returns confirmation -
On confirm, button is disabled and replaced with “dismissed” -
Replaced with warning (how?) No longer blocks MR (how?) -
❓ I think calling updateMergeRequestMutation will update the widget, but it only has the option to overriderequestedchanges, so we also need to modify it to have a new property called overrideSecurityPolicies that triggers the warning state -
❓ We also need a new mutation to save the event to audit or tie it into that new property
-
-
Update title on MR widget -
❓ Might be ee/app/assets/javascripts/vue_merge_request_widget/mixins/ready_to_merge.js
-
Verification steps
Edited by Alexander Turinske