GraphQL error when deleting a recently viewed item

Summary

GraphQL queries for recently viewed items return an error if the underlying has been deleted, or if user would need SAML to access any of the recent items.

Steps to reproduce

  1. View an issue
  2. Delete the issue
  3. Visit the homepage
  4. Boom

Different steps, same problem

(reproduced by @thutterer on Aug 5)

  1. Let your SAML (Okta) auth time out over night
  2. Open gitlab (still signed in)
  3. See the error
  4. Fix: Sign in to Okta, open Gitlab.com via Okta tile (SAML auth)
  5. See no error

Example Project

What is the current bug behavior?

image image

What is the expected correct behavior?

The deleted item should just be removed from the list. Ideally we would still return the desired number of items (e.g. the 5 most recently viewed), but it's acceptable to not do that for this immediately fix.

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)


(we will only investigate if the tests are passing)

Possible fixes

Patch release information for backports

If the bug fix needs to be backported in a patch release to a version under the maintenance policy, please follow the steps on the patch release runbook for GitLab engineers.

Refer to the internal "Release Information" dashboard for information about the next patch release, including the targeted versions, expected release date, and current status.

High-severity bug remediation

To remediate high-severity issues requiring an internal release for single-tenant SaaS instances, refer to the internal release process for engineers.

Edited by Thomas Hutterer