Zoekt shards should have their metadata updated whenever a project metadata changes

Proposal

Any time metadata stored in zoekt about the project gets updated, the metadata should be updated on the zoekt node

This includes the following (but should be verified by what is currently stored in the metadata in zoekt):

  • archived
  • visibility_level
  • repository_access_level ( in ProjectFeature )

There are some project events in https://gitlab.com/gitlab-org/gitlab/tree/master/app/events/projects. Evaluate if we can use those or if a new event is needed.

The following discussion from !195676 (merged) should be addressed:

  • @johnmason started a discussion: (+4 comments)

    @rkumar555 after a project is marked as archived, how soon would the indexer pick that up? I think we might actually have an edge case where the indexer won't update metadata for recently archived projects. What that means is those archived projects will still show up in search results because their zoekt shard metadata hasn't been updated to show that they are archived.

    Since archived projects are un-editable, they will never have their metadata updated since there aren't any indexing tasks. WDYT?

Edited by Changzheng Liu