Fix OpenID Connect Endpoint Protocols
Overview
- When visiting
/.well-known/oauth-authorization-serveron GDK, when SSL enabled. Many of the OAuth endpoints are mistakenly usinghttp, instead ofhttpswhich causes issues for clients that do not automatically redirect to secure counterparts.
Why
- This happens because the OpenID Doorkeeper gem uses
httpby default in all Rails environments exceptproduction. Many GitLab team members run GDK using SSL, but indevelopment, causing the issue we see here.
Implementation Plan
- Use
Gitlab.config.gitlab.protocolto override the value inconfig/initializers/doorkeeper_openid_connect.rb
Edited by Max Woolf