Remaining questions: Retrieval and display of security attributes

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Problems to solve

Security inventory project table row

How many attributes should we show in the table cell?

We should definitely show attributes for projects because they are applied directly to the project, but what should the limit be on how many to show in the cell before they overflow to a tooltip/drawer?

There is no limit on how many categories and attributes can be created and applied to a project, but we have finite space in the table cell and we shouldn't load more data than we need to in the GraphQL request that gets the initial inventory data. We can load more when the tooltip is triggered, and even more when the drawer is opened to show/edit all of the attributes applied to that project.

What order should they appear in?

Which categories/attributes should be prioritized to show in the overview, without having to hover or click to see more?

Categories:

  • Built in categories first?
  • Accidental order?: Whatever order (creation date or id) they happen to appear in the category list on the category/attribute configuration screen?
  • Alphabetical order?: A-Z
    • This allows some control without having to build any sorting UI: a user could name a category * Something and it would appear first.
    • This might not be as efficient as accidental.
  • Manual sorting (drag'n'drop)?

Attributes:

  • Accidental order?
  • Alphabetical order?
  • Manual sorting (drag'n'drop)?

Security inventory subgroup table row

Should we show attributes for subgroups? If so, how many attributes should we show?

It might not make sense to show a list of attributes for a subgroup if attributes cannot be directly applied to the subgroup.

If we decide to show attributes for subgroups, we should probably only show any given attribute once even if it's applied to every project in the subgroup.

The order in which we show attributes (which ones are prioritized to show in the overview) should probably match the order for projects.

Searching and filtering (results are only projects)

Do the attributes we show/prioritize change when a search or filter is applied?

Why? It might be confusing to filter by some attribute Location: Dublin if Location isn't visible in the search results.

  • When a search/filter query is made:
    • backend could re-sort the attributes so that the searched-for/filtered-by attributes appear first, or
    • frontend could assume the search/filter was successful and insert the searched-for/filtered-by attributes at the start

Proposal

  • On the attribute configuration screen (group):
    • Category list (left panel) should show built-in categories first, otherwise leave unsorted
    • Attributes list (table in right panel) should be sorted alphabetically by attribute name
  • On the attribute application screen (project):
    • Attributes list should be sorted alphabetically by attribute name
  • In the table cell on security inventory:
    • Don't show attributes in subgroup rows
    • For attributes in project rows:
      • Built-in category attributes should be shown first (category.editableState === 'LOCKED', category.editableState === 'PARTIALLY_EDITABLE')
      • Otherwise, attributes should be sorted alphabetically by attribute name
      • When attributes filters are applied, show the attributes that are being filtered by first
Edited by Miranda Fluharty