[Feature flag] Cleanup FF_GLAS_ENABLE_PHP_SUPPORT

Summary

This issue is to cleanup the FF_GLAS_ENABLE_PHP_SUPPORT feature flag, after the feature flag has been enabled by default for an appropriate amount of time in production.

Roll-out issue: [FF] FF_GLAS_ENABLE_PHP_SUPPORT (beta) SAST rol... (#543740 - closed)

Owners

• Team: groupstatic analysis
• Most appropriate slack channel to reach out to: #g_ast_static_analysis
• Best individual to reach out to: @thiagocsf
• PM: @connorgilbert

Stakeholders

Expectations

What might happen if this goes wrong?

Users wanting to disable PHP on Advanced SAST will need to rely on SAST_EXCLUDED_PATHS and/or SAST_EXCLUDED_ANALYZERS to control the behavior of the CI job created by SAST.gitlab-ci.yml.

Cleaning up the feature flag

1. Specify in the issue description if this feature will be removed completely or will be productized as part of the Feature Flag cleanup

2. Create a merge request to remove <feature-flag-name> feature flag. Ask for review and merge it.

   • Remove all references to the feature flag from the codebase.
   • Remove the YAML definitions for the feature from the repository.
   • Create a changelog entry.

   Remove FF_GLAS_ENABLE_PHP_SUPPORT feature flag ... (!201339 - merged) • Adam Cohen • 18.3

3. Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post.

   • /chatops run auto_deploy status <merge-commit-of-cleanup-mr>

4. Remove the FF_GLAS_ENABLE_PHP_SUPPORT flag from gitlab-advanced-sast

   https://gitlab.com/gitlab-org/security-products/analyzers/gitlab-advanced-sast/-/merge_requests/190+s

5. Remove the FF_GLAS_ENABLE_PHP_SUPPORT feature flag from the documentation.

   Remove FF_GLAS_ENABLE_PHP_SUPPORT feature flag ... (!201339 - merged) • Adam Cohen • 18.3

6. Implement step 4 from Refactor php-related SAST rules (#559997 - closed) • Adam Cohen • 18.4:

   Re-open and merge the code from Adjust SAST exists rule for php (!200262 - merged) • Adam Cohen • 18.4 now that FF_GLAS_ENABLE_PHP_SUPPORT has been removed.

   Adjust SAST exists rule for php (components/sast!37 - merged) • Adam Cohen

7. Close the feature issue to indicate the feature will be released in the current milestone.

8. If not already done, clean up the feature flag from all environments by running these chatops command in #production channel: /chatops run feature delete <feature-flag-name> --dev --pre --staging --staging-ref --production

   

9. Close this rollout issue.