Feature flag cleanup for webauthn_authentication_vue
Summary
This issue is to cleanup the <feature-flag-name>
feature flag, after the feature flag has been enabled by default for an appropriate amount of time in production.
Rollout issue: #554664 (closed)
Feature Issue: #393945 (closed)
Cleanup tasks:
- Remove feature flag logic
- Cleanup dead code paths see: !195371 (comment 2597477066)
note that we should remove it after
webauthn_authentication_vue
is cleanup. Instead, I suggest you create aapp/assets/javascripts/authentication/webauthn/authentication.js
file and you put there the newinitWebAuthnAuthentication
function. That way it will match the registration and authentication:
- app/assets/javascripts/authentication/webauthn/authentication.js -> initWebAuthnAuthentication
- app/assets/javascripts/authentication/webauthn/registration.js -> initWebAuthnRegistration
Owners
- Team: NAME_OF_TEAM
- Most appropriate slack channel to reach out to:
#g_TEAM_NAME
- Best individual to reach out to: NAME
- PM: NAME
Stakeholders
Expectations
What might happen if this goes wrong?
Cleaning up the feature flag
-
Specify in the issue description if this feature will be removed completely or will be productized as part of the Feature Flag cleanup -
Create a merge request to remove <feature-flag-name>
feature flag. Ask for review and merge it.-
Remove all references to the feature flag from the codebase. -
Remove the YAML definitions for the feature from the repository. -
Create a changelog entry.
-
-
Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post. -
/chatops run auto_deploy status <merge-commit-of-cleanup-mr>
-
-
Close the feature issue to indicate the feature will be released in the current milestone. -
If not already done, clean up the feature flag from all environments by running these chatops command in #production
channel:/chatops run feature delete <feature-flag-name> --dev --pre --staging --staging-ref --production
-
Close this rollout issue.
Edited by Eduardo Sanz García