Notify MR assignee when merge request is approved

Currently, there is no notification when a merge request has received all approvals. As a result, it's easy for a merge request to sit indefinitely until the assignee realizes it's been approved, and merges it. Customer requests some sort of notification be sent to the assignee once approvals have been obtained.

Full text from customer:


When a merge request is approved (but not “accepted”/landed/merged), there is no email sent to the originator of the merge request (or anyone else).

There should be!


I would guess if you were going to send such an email it would be to the assignee. While self-explanatory, there are a lot of details that make this maybe tricky to implement in a useful way. Like you probably wouldn't want to send this email immediately when a MR is approved, since it could easily be merged within a short time after the approval and not need any email notification. It seems as though this would be most useful if it caught a MR that was languishing, so you'd need to have some sort of time delay since it was approved. And then you have to constantly be looking at what MRs are in this state. Not sure what the best approach might be, if anything at all. Maybe it would just need to show up on the appropriate To Do list, but that is more passive than I think this user was hoping for.

cc/ @JobV @DouweM Thoughts?