Error 500 When Trying to Access /admin/application_settings after upgrading from 12.4.6 to 12.5.4
Summary
I get an Error 500 when trying to access /admin/application_settings after upgrading from 12.4.6 to 12.5.4
Steps to reproduce
Try to Access /admin/application_settings
Example Project
On-prem instance.
What is the current bug behavior?
Returns error 500
What is the expected correct behavior?
Loads the /admin/application_settings page
Relevant logs and/or screenshots
Processing by Explore::ProjectsController#trending as HTML
Completed 200 OK in 32ms (Views: 20.6ms | ActiveRecord: 3.2ms | Elasticsearch: 0.0ms)
Started GET "/admin/application_settings" for xx.xxx.xx.xx at 2019-12-13 10:27:06 +0000
Processing by Admin::ApplicationSettingsController#show as HTML
Completed 500 Internal Server Error in 353ms (ActiveRecord: 18.2ms | Elasticsearch: 0.0ms)
ActionView::Template::Error (undefined method `remove_source_branch_after_merge=' for #<Project id: >
Did you mean? remote_mirror_available_overridden_change):
11: = render_if_exists 'admin/application_settings/default_project_deletion_protection_setting', form: f
12: .form-group.visibility-level-setting
13: = f.label :default_project_visibility, class: 'label-bold'
14: = render('shared/visibility_radios', model_method: :default_project_visibility, form: f, selected_level: @application_setting.default_project_visibility, form_model: Project.new)
15: .form-group.visibility-level-setting
16: = f.label :default_snippet_visibility, class: 'label-bold'
17: = render('shared/visibility_radios', model_method: :default_snippet_visibility, form: f, selected_level: @application_setting.default_snippet_visibility, form_model: ProjectSnippet.new)
app/models/project.rb:645:in `initialize'
lib/gitlab/metrics/instrumentation.rb:161:in `block in initialize'
lib/gitlab/metrics/method_call.rb:36:in `measure'
lib/gitlab/metrics/instrumentation.rb:161:in `initialize'
app/views/admin/application_settings/_visibility_and_access.html.haml:14:in `block in _app_views_admin_application_settings__visibility_and_access_html_haml__401875350527911971_69878286249100'
app/views/admin/application_settings/_visibility_and_access.html.haml:1:in `_app_views_admin_application_settings__visibility_and_access_html_haml__401875350527911971_69878286249100'
app/views/admin/application_settings/general.html.haml:14:in `_app_views_admin_application_settings_general_html_haml__3367447124785056118_69878121421220'
app/controllers/application_controller.rb:108:in `render'
app/controllers/admin/application_settings_controller.rb:18:in `show'
lib/gitlab/session.rb:11:in `with_session'
app/controllers/application_controller.rb:450:in `set_session_storage'
lib/gitlab/i18n.rb:55:in `with_locale'
lib/gitlab/i18n.rb:61:in `with_user_locale'
app/controllers/application_controller.rb:444:in `set_locale'
lib/gitlab/middleware/rails_queue_duration.rb:27:in `call'
lib/gitlab/metrics/rack_middleware.rb:17:in `block in call'
lib/gitlab/metrics/transaction.rb:62:in `run'
lib/gitlab/metrics/rack_middleware.rb:17:in `call'
lib/gitlab/request_profiler/middleware.rb:17:in `call'
lib/gitlab/middleware/go.rb:20:in `call'
lib/gitlab/etag_caching/middleware.rb:13:in `call'
lib/gitlab/middleware/correlation_id.rb:16:in `block in call'
lib/gitlab/middleware/correlation_id.rb:15:in `call'
lib/gitlab/middleware/multipart.rb:117:in `call'
lib/gitlab/middleware/read_only/controller.rb:48:in `call'
lib/gitlab/middleware/read_only.rb:18:in `call'
lib/gitlab/middleware/basic_health_check.rb:25:in `call'
lib/gitlab/request_context.rb:32:in `call'
config/initializers/fix_local_cache_middleware.rb:9:in `call'
lib/gitlab/metrics/requests_rack_middleware.rb:49:in `call'
lib/gitlab/middleware/release_env.rb:12:in `call'
Output of checks
This bug happens on on-prem test installation.
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Current User: git Using RVM: no Ruby Version: 2.6.3p62 Gem Version: 2.7.9 Bundler Version:1.17.3 Rake Version: 12.3.3 Redis Version: 3.2.12 Git Version: 2.22.2 Sidekiq Version:5.2.7 Go Version: unknown rake aborted! NoMethodError: undefined method `remove_source_branch_after_merge=' for # Did you mean? remote_mirror_available_overridden_change /opt/gitlab/embedded/service/gitlab-rails/app/models/project.rb:645:in `initialize' /opt/gitlab/embedded/service/gitlab-rails/lib/tasks/gitlab/info.rake:48:in `block (3 levels) in ' /opt/gitlab/embedded/bin/bundle:23:in `load' /opt/gitlab/embedded/bin/bundle:23:in `' Tasks: TOP => gitlab:env:info
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 10.2.0 ? ... OK (10.2.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... Server: ldapmain LDAP authentication... Success LDAP users with access to your GitLab server (only showing the first 100 results) User output sanitized. Found 100 users of 100 limit.
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... skipped (no tmp uploads folder yet) Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... can't check, you have no projects Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.3) Git version >= 2.22.0 ? ... yes (2.22.2) Git user has default SSH configuration? ... yes Active users: ... 2 Is authorized keys file accessible? ... yes
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished