Log in E2E spec fails with new PAT UI
With !194582 (merged) , when running an E2E test that has to create a token manually through the UI, the test fails. It looks like the data-testid isn't present
QA_GITLAB_URL=https://gdk.test:3443 bundle exec rspec qa/specs/features/browser_ui/10_software_supply_chain_security/login/log_in_spec.rb
Produces:
Capybara::ElementNotFound:
Unable to find css "[data-testid=\"access-token-name-field\"]"
# ./qa/page/base.rb:146:in `find_element'
# ./qa/support/page/logging.rb:39:in `block in find_element'
# ./qa/support/page/logging.rb:214:in `log_slow_code'
# ./qa/support/page/logging.rb:39:in `find_element'
# ./qa/page/base.rb:276:in `fill_element'
# ./qa/support/page/logging.rb:101:in `block in fill_element'
# ./qa/support/page/logging.rb:214:in `log_slow_code'
# ./qa/support/page/logging.rb:101:in `fill_element'
# ./qa/page/component/access_tokens.rb:71:in `fill_token_name'
# ./qa/resource/personal_access_token.rb:49:in `block in fabricate!'
# ./qa/scenario/actable.rb:16:in `perform'
# ./qa/resource/personal_access_token.rb:47:in `fabricate!'
# ./qa/resource/base.rb:60:in `block (2 levels) in fabricate_via_browser_ui!'
# ./qa/resource/base.rb:117:in `log_and_record_fabrication'
# ./qa/resource/base.rb:60:in `block in fabricate_via_browser_ui!'
# ./qa/resource/base.rb:107:in `do_fabricate!'
# ./qa/resource/base.rb:59:in `fabricate_via_browser_ui!'
# ./qa/runtime/user/store.rb:253:in `create_api_token_via_ui!'
# ./qa/runtime/user/store.rb:185:in `create_api_client'
# ./qa/runtime/user/store.rb:33:in `admin_api_client'
# ./qa/ce/strategy.rb:45:in `initialize_admin_api_client!'
# ./qa/ce/strategy.rb:17:in `perform_before_hooks'
# ./qa/ee/strategy.rb:11:in `perform_before_hooks'
# ./qa/runtime/release.rb:25:in `public_send'
# ./qa/runtime/release.rb:25:in `method_missing'
# ./qa/specs/spec_helper.rb:86:in `block (2 levels) in <top (required)>'
Top 0 slowest examples (0 seconds, 0.0% of total time):
Finished in 55.01 seconds (files took 1.53 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples
This also raises a maintenancetest-gap issue, as one of the e2e tests should have failed in !194582 (merged), it didn't because the tests are creating the token through the api. We should have at least one test creating through the UI
Edited by 🤖 GitLab Bot 🤖