Skip to content

Update approval rule reviewer dropdown to only take list of users eligible for that rule

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

[Part of Intelligent Reviewer Assignment]

Because the reviewer assignment dropdown used for all types of reviewer assignment (including filtered/specific assignments like to approval rules) evolved from a single dropdown for no specific purpose, it handles updating the main (total/complete/master) list of reviewers internally. This doesn't really fit with the model of selecting reviewers for a given approval rule and specific dropdowns filtered to only show the correct users.

In #548622, we will move the logic for changing the reviewer list to a single location. That alleviates the individual dropdown from needing to maintain context of the full list even when it can't show the whole list.

We should now update the dropdown to take/expect the full list of displayable reviewers. It should not need to be responsible for knowing what rule it is for; a parent component should generate the list for the specific rule and pass it into a more generalized dropdown component that can simply display the list it is given and report additions/removals.

Edited by 🤖 GitLab Bot 🤖