Skip to content

Follow-up from "Add virtual registry group sidebar nav item"

The following discussion from !192931 (merged) should be addressed:

  • @10io started a discussion:

    This condition check is very similar to what is happening here.

    I'm wondering if we should simply go ahead and put the conditions:

    • 2 feature flags checks.
    • dependency proxy feature check.
    • licensed feature check.

    In a single method on either:

    • a view helper or
    • even directly as a class method on ::VirtualRegistries
  • In addition to the above, further refactoring can be done in some of the specs to reduce duplication. In the ee/spec/requests/api/virtual_registries/packages/maven/ specs we have repeated blocks of individual shared examples to check dep proxy enabled, feature flag and now virtual registry setting.

  • Check if these checks to push abilities and licensed feature to the frontend can be consolidated. !203628 (comment 2811938434)

Edited by Fiona McCawley