Skip to content

Update CommitList GraphQL query to allow keyset pagination

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Follow-up from CommitList GraphQL query (#541920 - closed)

Blocked by Add support for cursor based pagination in the ... (#542535 - closed)

Once the FindCommits RPC has been updated to allow keyset pagination we need to update the CommitList GraphQL query to:

  1. add a new resolver arg to be passed to the RPC as pagination_params.page_token.
  2. add a new field in the resolver to return pagination_cursor.next_cursor in the response.

It's not immediately clear how we should name these in the graphql side. I've found these docs for keyset pagination in graphql, however, they only reference queries to AR. We need to query gitaly so we will need to modify the approach. I suspect we'll need to manually return these values following the same structure as the other graphql queries that support keyset pagination. I expect it follows the same format as outlined in the official graphql pagination docs

We need to performance test using all of the different filters on a large repository to ensure it performs well. We may need to configure and tune complexity values for the filter args.

Edited by 🤖 GitLab Bot 🤖