Skip to content

"Needs approval" badge should link to the approval page

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Proposal

Currently, when a deployment needs approval, the "Needs approval" badge is displayed on the Environments and Environments folder pages. However, this badge does not function as a link to the approval page. This enhancement would make the "Needs approval" badge clickable, linking directly to the approval page for that deployment.

Implementation guide

Update app/assets/javascripts/environments/components/deployment.vue.

Use this.deployment?.webPath || this.deploymentJob?.webPath || this.deploymentJob?.buildPath similarly to how it's done for deployment status link to make the badge link to the appropriate approval page.

Related to https://gitlab.com/gitlab-com/account-management/commercial/arcesium/-/issues/38 (internal)

Edited by 🤖 GitLab Bot 🤖