Skip to content

Approval status not visible on deployments history page

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Summary

Approval status is not visible on the deployments history page, causing confusion for users who need to check approval status. The approval icon is confusing, represents a link rather than an action, and there's no clear indication if approval is present.

Steps to reproduce

  1. Navigate to a project with protected environments requiring approval
  2. Go to the deployments history page
  3. Observe that there is no clear indication of approval status for pending deployments

What is the current bug behavior?

  1. Approval status is not visibly indicated on the deployments history page
  2. The approval icon is confusing and its purpose is not clear
  3. The icon represents a link rather than an action
  4. Users have to click each pending deployment to see if approval is needed

What is the expected correct behavior?

  1. Clear visual indication of approval status should be present on the deployments history page
  2. The approval icon should clearly indicate its purpose
  3. Users should be able to determine at a glance which deployments need approval

The button should clearly indicate:

  • the deployment is fully approved
  • the deployment is waiting for approval
  • the user can approve the current deployment
  • the user already approved the current deployment

Relevant logs and/or screenshots

image

Possible fixes

Add indication of the required approval count to deployment type. Currently, we have approvalSummary, but it's only available for 1 deployment at a time. We can add a field can_approve which will indicate if user can approve and approval from the user is needed.

Note: This might introduce a performance issue, so we should at least check the finished state on frontend.

Related to https://gitlab.com/gitlab-com/account-management/commercial/arcesium/-/issues/38 (internal)

Edited by 🤖 GitLab Bot 🤖