Use ApplicationSettings::UpdateService for jsonb column

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Problem

Using ApplicationSettings::UpdateService with jsonb does not work as expected.

[11] pry(main)> ApplicationSettings::UpdateService.new(Gitlab::CurrentSettings.current_application_settings, nil, { database_reindexing: { minimum_index_size: 3.gigabytes } } ).execute
=> false
[12] pry(main)> Gitlab::CurrentSettings.current_application_settings.database_reindexing
=> {"reindexing_minimum_index_size"=>2147483648, "reindexing_minimum_relative_bloat_size"=>0.2}

Solution

  • Improve existing service to make it compatible with jsonb column

https://docs.gitlab.com/development/application_settings/

cc @alipniagov @terrichu

Edited by 🤖 GitLab Bot 🤖