Coverage-Check Rule does not apply
Summary
Code Coverage Approval Rule is overwritten and not working
Steps to reproduce
- Enable Coverage-Check Rule
- Create a pipeline on
mainwith code coverage - Create another branch off
main - With another user
- Edit the gitlab-ci.yml file of that branch to reduce the code coverage
- MR can still be merged w/o approval
Example Project
mfanGitLab/simplecodecoverage!3
What is the current bug behavior?
MergeRequest is able to merge w/o approvals
What is the expected correct behavior?
Approvals are needed because code coverage quality decreased
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: \\\\\\\`sudo gitlab-rake gitlab:env:info\\\\\\\`) (For installations from source run and paste the output of: \\\\\\\`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production\\\\\\\`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of: \\\`sudo gitlab-rake gitlab:check SANITIZE=true\\\`) (For installations from source run and paste the output of: \\\`sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true\\\`) (we will only investigate if the tests are passing)
Possible fixes
Edited by Max Fan

