Directory/file page locking: Address UX issues for children of locked directories

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Context

@alyssatrinh #224475 (comment 2451043116):

In our current implementation on production, when users lock a directory, a lock icon populates on all the files inside the directory in the file list. However, if users navigate to a file, they can still click the "Lock" button. This is confusing because in the file list, we communicate that sub-files are "locked," but when users navigate to the file, the presence of the "Lock" button communicates that the file is unlocked.

Production	MR !186291 (merged)
production.mov UX Issue File list shows locked status, but the file page shows "Lock" button which communicates an unlocked status	mr.mov UX Issue File list shows locked status, but the file page shows "Lock" button which communicates an unlocked status If a user tries to lock a file inside a locked directory, no error message or system confirmation is shown.

Questions

• When a user locks a directory, do we actually "lock" the children files in that directory?
• Or were we just putting a "lock" icon on all children files just to communicate (poorly) that the directory was locked?

Initial front-end investigation

@psjakubowska #224475 (comment 2451520320):

We do not lock the children, but the lock icon is added to all the children to indicate that the directory is locked. I've noticed now that there's even a title on the icon with that contest, but there must be a bug causing the tooltip to not render (#536182 (closed))

....

To me, it seems like we must have some check somewhere that does not allow to lock a file of an already locked directory, but we do that silently.

I'd like the backend team to confirm that though. We can then create an issue for disabling the lock controls of such files and maybe adding more details in the tooltip next to the file icon.

Back-end investigation needed

When users lock a directory, navigate to a file inside the directory, then try to "Lock" the file, no error message or system confirmation of successful "Lock" status is shown.

We need to understand whether we DO or DO NOT allow a file to be locked, if it is inside a locked directory.

Design recommendation

The design recommendation is dependent on the results of the remaining investigation:

Condition	Design Proposal
If we DO allow children files of locked directories to be "locked"	Directory page: when a user locks a directory, do not show the glyph on children files in the file list. This is confusing, and communicates a "locked" status of the children files even though they are not actually "locked" We would not need to fix Lock icon tooltip for locked directory child it... (#536182 - closed). File page: when a user locks a directory, and navigate to a child file page, allow the user to "Lock" this file. Currently, the "Lock" button is enabled but clicking the "Lock" button does not create a lock or return an error. This is confusing.
If we DO NOT allow children files of locked directories to be "locked"	Mental model assumption If children files inside a locked directory cannot be "locked," then they effectively act like "locked" files which cannot be unlocked/locked unless a user has the correct permissions. Treat child files like "locked" files. Directory page: when a user locks a directory, show the glyph on all children files in the file list (as is). Fix Lock icon tooltip for locked directory child it... (#536182 - closed) to communicate status to users. File page: when a user locks a directory, and navigate to a child file page, show the locked icon next the file name to denote that the file is "locked." Show appropriate messaging about locking/unlocking permissions in the tooltip on hover of the locked icon (or in the future the lock icon disclosure in &13019). Currently, the "Lock" button is enabled but clicking the "Lock" button does not create a lock or return an error. This is confusing.