[Feature flag] Cleanup vulnerability_signatures_dedup_by_type

Summary

This issue is to cleanup the vulnerability_signatures_dedup_by_type feature flag, after the feature flag has been enabled by default for an appropriate amount of time in production.

vulnerability_signatures_dedup_by_type introduces a fix that includes the signature name into the comparison so that we do not deduplicated unrelated findings anymore as illustrated in Semgrep-based SAST reports does not report all ... (#469038 - closed) • Julian Thome • 17.11.

This issue is about cleaning up vulnerability_signatures_dedup_by_type which was introduced in [Feature flag] Enable vulnerability_signatures_... (#525071 - closed) • Julian Thome • 17.11 • On track.

Owners

• Team: groupstatic analysis
• Most appropriate slack channel to reach out to: #g_ast-static-analysis
• Best individual to reach out to: @julianthome
• PM: @thiagocsf

Stakeholders

Expectations

What might happen if this goes wrong?

Cleaning up the feature flag

• Specify in the issue description if this feature will be removed completely or will be productized as part of the Feature Flag cleanup
• Create a merge request to remove <feature-flag-name> feature flag. Ask for review and merge it.
  • Remove all references to the feature flag from the codebase.
  • Remove the YAML definitions for the feature from the repository.
  • Create a changelog entry.
• Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post.
  • /chatops run auto_deploy status <merge-commit-of-cleanup-mr>
• Close the feature issue to indicate the feature will be released in the current milestone.
• If not already done, clean up the feature flag from all environments by running these chatops command in #production channel: /chatops run feature delete <feature-flag-name> --dev --pre --staging --staging-ref --production
• Close this rollout issue.