Modify UI for Service account PAT expiration options

Is there a better way to word the Service access token expiration option in the settings?

Context

Slack thread

@eduardosanz:

Would you oppose if we refer to services accounts' (SA) personal access tokens (PATs) as service access tokens (SATs)? This would simplify the naming and align it with other access tokens personal/group/project/service/impersonation access tokens. We are already using in the UI:

@adil.farrukh:

... Our naming convention PATs, PrATs, GrATs + all the other token types is already unfamiliar for folks who don't work with them regularly. From an entity perspective, service account is an account, while access token can be optionally generated for it

@idurham:

What if we moved the option under the Personal access tokens heading? Change option text to something like: Require expiration dates for service accounts, ... description text to something like: Forces new personal access tokens for service accounts to require an <a>expiration date</a>., for self hosted, we could move the option under Personal / project / group access token expiration heading

Proposal

Adjust the wording of the existing Service access token expiration option and move it within the UI.

  • Option text: Require expiration date for service accounts
    • Option text - Longer: Require expiration date for service account personal access tokens
  • Description text: Forces new personal access tokens for service accounts to require an expiration date.

Mockups

Gitlab.com Gitlab Self-Managed
image__1_ image
Edited by Isaac Durham