Use constants instead of hard-coding roles on pipeline_variables_minimum_override_role

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Original issue: #526130 (closed)

Summary

We can improve code quality and use constants instead of hardcoded roles - !185458 (comment 2432498565)

Improvements

Maybe we can invert the constants and do some refactoring:

NO_ONE_ALLOWED_ROLE = 'no_one_allowed'
DEVELOPER_ROLE = 'developer'
# ...

PIPELINE_VARIABLES_OVERRIDE_ROLES = {
  NO_ONE_ALLOWED_ROLE.to_sym => 1,
  DEVELOPER_ROLE.to_sym => 2,
  # ...
}.freeze

Risks

Involved components

Optional: Intended side effects

Optional: Missing test coverage