Cleanup Feature Flag enable_secrets_provider_check_on_pre_assign_runner_checks
Summary
This issue is to cleanup the enable_secrets_provider_check_on_pre_assign_runner_checks feature flag, after the feature flag has been enabled by default for an appropriate amount of time in production.
Owners
- Team: SCSS Pipeline Security
- Most appropriate slack channel to reach out to:
g_scss_pipeline_security - Best individual to reach out to: @jmallissery
- PM: Scott Hampton
Cleaning up the feature flag
-
Create a merge request to remove enable_secrets_provider_check_on_pre_assign_runner_checksfeature flag. Ask for review and merge it.-
Remove unused class -
Remove unused tests -
Remove references to DropSecretsProviderNotFoundBuildsServiceclass in tests -
Remove all references to the feature flag enable_secrets_provider_check_on_pre_assign_runner_checksfrom the codebase. -
Remove the YAML definition file for the feature from the repository - ee/config/feature_flags/gitlab_com_derisk/enable_secrets_provider_check_on_pre_assign_runner_checks.yml -
Create a changelog entry.
-
-
Ensure that the cleanup MR has been deployed to both production and canary by running /chatops run auto_deploy status <merge-commit-of-cleanup-mr> -
If not already done, clean up the feature flag from all environments by running these chatops command in #productionchannel:/chatops run feature delete <feature-flag-name> --dev --pre --staging --staging-ref --production -
Close this issue.
Edited by Jayakrishnan Mallissery