Move `showBlobControls` logic to header area
The following discussion from !185342 (merged) should be addressed:
-
@ms.mondrian started a discussion: (+9 comments) the pipeline failure confuses me. i don't really know what test actually fails
🤔
Context
This is a wild one so hear me out
- We attempted this refactor as part of !185342 (merged) because
- The current check locates in the
blob_controlscomponent, which means we're making unnecessary graphql call to fetch information - That call is causing a cache warning from graphql (see !185342 (comment 2417347066))
- The current check locates in the
- However, this refactor will cause feature tests to fail because tree controls are being rendered on blob page. See !185342 (comment 2421121722)
- What's tripping are:
- This failure only happens in CI. Running the same test in gdk does not produce this bug
- This bug cannot be reproduced when manually check the same flow
- This somehow is causing the components rendering in different order in the DOM than what we have in the code (i know!) !185342 (comment 2428708882)
To unblock !185342 (merged), we've removed this refactor from that branch. But the buggy code can be found on this branch.
Expected outcome
-
showBlobControlsshould be moved toheader_area - blob controls should not render in tree view
- all tests pass
Edited by Chaoyue Zhao
