SAML Group Link Delete Endpoint - Names with periods are not found

Summary

When deleting a saml group link with a security group name that contains a period for example, sg.something.reader, the API returns a not found error. When listing all saml links for a project, the list API returns sg.something.reader as a valid name.

Steps to reproduce

  1. Create a group
  2. Using the add saml group link endpointto add a group called sg.something.reader and assign reader permissions
  3. Using the list group link endpoint validate sg.something.reader is assigned to the group
  4. Using the delete group link endpoint delete sg.something.reader. The message returned should be either a 404 or a "not found" message.

Example Project

What is the current bug behavior?

When querying a valid security group that has a period in the name using the delete endpoint returns either

{ "message": "Linked SAML group link not found" }

or

404 Not found

What is the expected correct behavior?

The API should return a 204 status code as described in the documentation with the saml group link being deleted.

Relevant logs and/or screenshots

Support ticket #614917

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

Expand for output related to GitLab environment info 
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)


(we will only investigate if the tests are passing)

Possible fixes

Edited by 🤖 GitLab Bot 🤖