Follow-up from "Use source repository storage for forking process"
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
The following discussion from !183992 (merged) should be addressed:
-
@jwoodwardgl started a discussion: nitpick (non-blocking): related to my other comment, I feel like the logic for
object_pool_params
would make more sense in this service.unless @project.forked? new_params.merge!(pool_repository: @project.pool_repository || @project.create_new_pool_repository) end
Problem
Project#object_pool_params
is defined in Project
but only used in ForkService
. It's quite confusing and difficult to track it now.
Suggestion
Move Project#object_pool_params
logic to ForkService
Edited by 🤖 GitLab Bot 🤖