When a related merge request is from a project that requires SAML sign in the page displays an error
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Problem
When linked MRs are behind SAML, but the work item is not, users can run into a case where the SAML authentication has expired and the MR can't be retrieved. Currently this results in an error without an obvious recovery step.
Originally reported from Slack
While viewing Project graphql query is returning incorrect pa... (#512677 - closed) I was seeing this warning
The graphql request returned an error Cannot return null for non-nullable field MergeRequest.project
I mentioned in slack and @Taucher2003 verified that he could see the related MRs and pointed out one of the related MRs was in the .com project which requires SAML sign-in. After re-authenticating I was able to load the related MRs.
We should fix the logic so it can gracefully handle these errors. I'm not sure on what we would show, maybe it should display a message that the user needs to re-authenticate to view the full list?
Proposal
We should be able to detect when the MR project is inaccessible requiring authentication, similar to what we do for Todos in those projects.
When an MR is inaccessible we should provide users with a direct action to authenticate and resolve the problem, making all MRs accessible.