Rubocop rules that span multiple files might introduce broken master

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Problem

We noticed that after !182719 (merged) we broke master with https://gitlab.com/gitlab-org/gitlab/-/jobs/9254288890 but in https://gitlab.com/gitlab-org/gitlab/-/jobs/9252711111 we can see that this MR never ran Rubocop against the files which broke. It seems like we're optimizing rubocop to only check changed files. But this doesn't work when rubocop rules can interact across files like EnsureFactoryForTable.

Solution

If we want interactions across files in our Rubocop rules I believe we need to run a full rubocop in tier 3 pipelines.