Skip to content

Allow reviewer to suggest a commit message when suggesting changes

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

What

There are currently three options to commit suggested changes:

  • Use the default commit message
  • Configure a message template
  • Let the author of the MR customize the commit message

I would like to propose a fourth option:

  • Let the reviewer customize the commit message and offer this to the author as part of the suggestion

Why

Often times, when applying suggested changes

  • Authors might want to get through quickly and therefore might tend to take the default that is offered to them
  • Authors already need to wrap their head around what the reviewer is suggesting while the reviewer already knows what the change is about when they are done writing their suggestion

Mockups

image
(The syntax is just an idea) image image

Furthermore

  • Technically, we could allow any argument of git commit (like --fixup (#325951), --squash, --trailer (this could be useful for #526258))
Edited by 🤖 GitLab Bot 🤖