Spec failure in ee/spec/services/ci_cd/github_setup_service_spec.rb
Seen here: https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/56325948
Failure:
1) CiCd::GithubSetupService#execute creates the webhook in the background
Failure/Error: subject.execute
URI::InvalidURIError:
bad URI(is not URI?):
# ./ee/app/services/ci_cd/github_integration_setup_service.rb:51:in `import_uri'
# ./ee/app/services/ci_cd/github_integration_setup_service.rb:29:in `repository_url'
# ./ee/app/services/ci_cd/github_integration_setup_service.rb:35:in `configuration_params'
# ./ee/app/services/ci_cd/github_integration_setup_service.rb:20:in `github_params'
# ./ee/app/services/ci_cd/github_integration_setup_service.rb:16:in `github_integration'
# ./ee/app/services/ci_cd/github_integration_setup_service.rb:10:in `execute'
# ./ee/app/services/ci_cd/github_setup_service.rb:21:in `setup_project_integration'
# ./ee/app/services/ci_cd/github_setup_service.rb:11:in `execute'
# ./ee/spec/services/ci_cd/github_setup_service_spec.rb:14:in `block (3 levels) in <top (required)>'
# ------------------
# --- Caused by: ---
# NoMethodError:
# undefined method `to_str' for nil:NilClass
# Did you mean? to_s
# to_r
# ./ee/app/services/ci_cd/github_integration_setup_service.rb:51:in `import_uri'
2) CiCd::GithubSetupService#execute sets up GithubService project integration
Failure/Error: subject.execute
URI::InvalidURIError:
bad URI(is not URI?):
# ./ee/app/services/ci_cd/github_integration_setup_service.rb:51:in `import_uri'
# ./ee/app/services/ci_cd/github_integration_setup_service.rb:29:in `repository_url'
# ./ee/app/services/ci_cd/github_integration_setup_service.rb:35:in `configuration_params'
# ./ee/app/services/ci_cd/github_integration_setup_service.rb:20:in `github_params'
# ./ee/app/services/ci_cd/github_integration_setup_service.rb:16:in `github_integration'
# ./ee/app/services/ci_cd/github_integration_setup_service.rb:10:in `execute'
# ./ee/app/services/ci_cd/github_setup_service.rb:21:in `setup_project_integration'
# ./ee/app/services/ci_cd/github_setup_service.rb:11:in `execute'
# ./ee/spec/services/ci_cd/github_setup_service_spec.rb:20:in `block (3 levels) in <top (required)>'
# ------------------
# --- Caused by: ---
# NoMethodError:
# undefined method `to_str' for nil:NilClass
# Did you mean? to_s
# to_r
# ./ee/app/services/ci_cd/github_integration_setup_service.rb:51:in `import_uri'
Finished in 24 minutes 32 seconds (files took 52.19 seconds to load)
3170 examples, 2 failures
Failed examples:
rspec ./ee/spec/services/ci_cd/github_setup_service_spec.rb:11 # CiCd::GithubSetupService#execute creates the webhook in the background
rspec ./ee/spec/services/ci_cd/github_setup_service_spec.rb:17 # CiCd::GithubSetupService#execute sets up GithubService project integration
Spec run list:
ee/spec/lib/gitlab/elastic/search_results_spec.rb
ee/spec/models/burndown_spec.rb
ee/spec/features/boards/sidebar_spec.rb
ee/spec/models/project_spec.rb
ee/spec/features/promotion_spec.rb
ee/spec/features/issues/form_spec.rb
ee/spec/policies/group_policy_spec.rb
ee/spec/services/epic_issues/create_service_spec.rb
ee/spec/features/merge_request/user_sets_approvers_spec.rb
ee/spec/features/projects/path_locks_spec.rb
ee/spec/features/projects/audit_events_spec.rb
ee/spec/lib/gitlab/elastic/project_search_results_spec.rb
ee/spec/models/merge_request_spec.rb
ee/spec/features/projects/new_project_spec.rb
ee/spec/features/epics/update_epic_spec.rb
ee/spec/services/projects/create_service_spec.rb
ee/spec/uploaders/workers/object_storage/migrate_uploads_worker_spec.rb
ee/spec/features/es_group_search_spec.rb
ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb
ee/spec/features/projects/merge_requests/user_approves_merge_request_spec.rb
ee/spec/workers/elastic_indexer_worker_spec.rb
ee/spec/services/projects/update_remote_mirror_service_spec.rb
ee/spec/models/push_rule_spec.rb
ee/spec/services/epic_issues/update_service_spec.rb
ee/spec/models/concerns/elastic/repository_spec.rb
ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb
ee/spec/services/issues/export_csv_service_spec.rb
ee/spec/models/ci/build_spec.rb
ee/spec/requests/api/v3/github_spec.rb
ee/spec/services/ci/pipeline_trigger_service_spec.rb
ee/spec/features/ci_shared_runner_warnings_spec.rb
ee/spec/controllers/groups/epic_issues_controller_spec.rb
ee/spec/requests/api/merge_request_approvals_spec.rb
ee/spec/models/remote_mirror_spec.rb
ee/spec/requests/api/group_boards_spec.rb
ee/spec/requests/api/issue_links_spec.rb
ee/spec/finders/epics_finder_spec.rb
ee/spec/features/admin/admin_audit_logs_spec.rb
ee/spec/features/ci_shared_runner_settings_spec.rb
ee/spec/controllers/boards/lists_controller_spec.rb
ee/spec/services/issue_links/list_service_spec.rb
ee/spec/features/projects/milestones/milestone_spec.rb
ee/spec/lib/gitlab/geo/log_cursor/daemon_spec.rb
ee/spec/services/users/migrate_to_ghost_user_service_spec.rb
ee/spec/requests/api/project_push_rule_spec.rb
ee/spec/features/projects/tree/create_directory_spec.rb
ee/spec/policies/merge_request_policy_spec.rb
ee/spec/features/projects/pipelines/pipeline_spec.rb
ee/spec/controllers/groups/analytics_controller_spec.rb
ee/spec/requests/api/project_mirror_spec.rb
ee/spec/models/concerns/ee/deployment_platform_spec.rb
ee/spec/features/project_variables_spec.rb
ee/spec/models/project_services/jenkins_service_spec.rb
ee/spec/services/geo/wiki_sync_service_spec.rb
ee/spec/serializers/merge_request_widget_entity_spec.rb
ee/spec/controllers/projects/approvers_controller_spec.rb
ee/spec/models/geo_node_spec.rb
ee/spec/features/projects/settings/issues_settings_spec.rb
ee/spec/models/ee/protected_ref_access_spec.rb
ee/spec/features/epics/new_epic_spec.rb
ee/spec/requests/api/settings_spec.rb
ee/spec/services/ldap_group_reset_service_spec.rb
ee/spec/features/epics/epics_list_spec.rb
ee/spec/services/epic_issues/destroy_service_spec.rb
ee/spec/controllers/admin/application_settings_controller_spec.rb
ee/spec/policies/epic_policy_spec.rb
ee/spec/features/groups/analytics_spec.rb
ee/spec/services/merge_requests/merge_service_spec.rb
ee/spec/services/boards/create_service_spec.rb
ee/spec/services/quick_actions/interpret_service_spec.rb
ee/spec/services/geo/file_download_service_spec.rb
ee/spec/features/admin/admin_reset_pipeline_minutes_spec.rb
ee/spec/models/path_lock_spec.rb
ee/spec/finders/log_finder_spec.rb
ee/spec/models/geo/project_registry_spec.rb
ee/spec/services/projects/update_service_spec.rb
ee/spec/features/boards/group_boards/user_edits_issues_spec.rb
ee/spec/services/boards/update_service_spec.rb
ee/spec/models/concerns/elastic/issue_spec.rb
ee/spec/models/board_spec.rb
ee/spec/features/projects/settings/push_rules_settings_spec.rb
ee/spec/controllers/projects/variables_controller_spec.rb
ee/spec/requests/api/v3/ldap_group_links_spec.rb
ee/spec/features/epics/delete_epic_spec.rb
ee/spec/features/merge_request/user_sees_approval_widget_spec.rb
ee/spec/models/concerns/elastic/merge_request_spec.rb
ee/spec/services/projects/destroy_service_spec.rb
ee/spec/requests/git_http_geo_spec.rb
ee/spec/workers/geo/project_sync_worker_spec.rb
ee/spec/features/boards/boards_spec.rb
ee/spec/services/geo/file_upload_service_spec.rb
ee/spec/services/issue_links/destroy_service_spec.rb
ee/spec/services/geo/rename_repository_service_spec.rb
ee/spec/lib/gitlab/elastic/indexer_spec.rb
ee/spec/models/issue_spec.rb
ee/spec/workers/repository_update_remote_mirror_worker_spec.rb
ee/spec/mailers/emails/csv_export_spec.rb
ee/spec/features/admin/admin_license_spec.rb
ee/spec/services/geo/hashed_storage_migration_service_spec.rb
ee/spec/lib/gitlab/repository_size_error_spec.rb
ee/spec/services/epic_issues/list_service_spec.rb
ee/spec/workers/elastic_batch_project_indexer_worker_spec.rb
ee/spec/finders/todos_finder_spec.rb
ee/spec/models/concerns/elastic/project_spec.rb
ee/spec/controllers/projects/service_desk_controller_spec.rb
ee/spec/models/geo/event_log_spec.rb
ee/spec/helpers/ee/lock_helper_spec.rb
ee/spec/requests/api/v3/builds_spec.rb
ee/spec/features/projects/show_project_spec.rb
ee/spec/lib/ee/gitlab/auth/ldap/sync/groups_spec.rb
ee/spec/services/ci_cd/setup_project_spec.rb
ee/spec/models/issue_link_spec.rb
ee/spec/workers/chat_notification_worker_spec.rb
ee/spec/lib/gitlab/slash_commands/run_spec.rb
ee/spec/lib/ee/audit/project_changes_auditor_spec.rb
ee/spec/services/geo/job_artifact_deleted_event_store_spec.rb
ee/spec/serializers/geo_project_registry_entity_spec.rb
ee/spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb
ee/spec/requests/api/issues_spec.rb
ee/spec/uploaders/workers/object_storage/background_move_worker_spec.rb
ee/spec/workers/post_receive_spec.rb
ee/spec/models/project_services/jenkins_deprecated_service_spec.rb
ee/spec/services/geo/repository_destroy_service_spec.rb
ee/spec/services/projects/update_repository_storage_service_spec.rb
ee/spec/controllers/groups/boards_controller_spec.rb
ee/spec/features/projects/classification_label_on_project_pages_spec.rb
ee/spec/models/project_services/github_service/status_message_spec.rb
ee/spec/models/ci/pipeline_spec.rb
ee/spec/features/admin/admin_dashboard_spec.rb
ee/spec/views/shared/_mirror_status.html.haml_spec.rb
ee/spec/features/projects/settings/ee/external_authorization_service_settings_spec.rb
ee/spec/finders/merge_requests_finder_spec.rb
ee/spec/features/geo_node_spec.rb
ee/spec/services/slash_commands/global_slack_handler_spec.rb
ee/spec/lib/gitlab/authority_analyzer_spec.rb
ee/spec/controllers/projects/jobs_controller_spec.rb
ee/spec/features/signup_spec.rb
ee/spec/serializers/project_mirror_entity_spec.rb
ee/spec/bin/sidekiq_cluster_spec.rb
ee/spec/workers/object_storage_upload_worker_spec.rb
ee/spec/features/boards/focus_mode_spec.rb
ee/spec/services/geo/hashed_storage_attachments_migration_service_spec.rb
ee/spec/workers/export_csv_worker_spec.rb
ee/spec/services/issues/build_service_spec.rb
ee/spec/lib/ee/gitlab/ci/config_spec.rb
ee/spec/models/license_spec.rb
ee/spec/features/admin/admin_push_rules_spec.rb
ee/spec/services/application_settings/update_service_spec.rb
ee/spec/models/approvable_spec.rb
ee/spec/controllers/ee/projects/application_controller_spec.rb
ee/spec/routing/webhook_routes_spec.rb
ee/spec/requests/api/variables_spec.rb
ee/spec/finders/labels_finder_spec.rb
ee/spec/services/projects/group_links/destroy_service_spec.rb
ee/spec/controllers/projects/settings/repository_controller_spec.rb
ee/spec/controllers/search_controller_spec.rb
ee/spec/models/group_spec.rb
ee/spec/services/ee/users/destroy_service_spec.rb
ee/spec/views/layouts/nav/sidebar/_group.html.haml_spec.rb
ee/spec/services/projects/setup_ci_cd_spec.rb
ee/spec/lib/gitlab/git_access_wiki_spec.rb
ee/spec/controllers/groups/billings_controller_spec.rb
ee/spec/migrations/remove_system_hook_from_geo_nodes_spec.rb
ee/spec/workers/repository_remove_remote_worker_spec.rb
ee/spec/services/projects/group_links/create_service_spec.rb
ee/spec/services/geo/hashed_storage_attachments_event_store_spec.rb
ee/spec/services/wiki_pages/update_service_spec.rb
ee/spec/requests/group_routing_spec.rb
ee/spec/controllers/projects/settings/slacks_controller_spec.rb
ee/spec/models/ee/project_authorization_spec.rb
ee/spec/controllers/oauth/geo_auth_controller_spec.rb
ee/spec/services/geo/upload_deleted_event_store_spec.rb
ee/spec/services/epics/update_service_spec.rb
ee/spec/lib/ee/gitlab/ci/pipeline/chain/limit/size_spec.rb
ee/spec/services/geo/hashed_storage_migrated_event_store_spec.rb
ee/spec/lib/ee/api/helpers/runner_spec.rb
ee/spec/services/projects/slack_application_install_service_spec.rb
ee/spec/lib/gitlab/git_access_spec.rb
ee/spec/controllers/groups/hooks_controller_spec.rb
ee/spec/views/admin/groups/_form.html.haml_spec.rb
ee/spec/serializers/variable_entity_spec.rb
ee/spec/models/approver_group_spec.rb
ee/spec/requests/omniauth_kerberos_spnego_spec.rb
ee/spec/services/boards/list_service_spec.rb
ee/spec/features/dashboards/group_dashboard_with_external_authorization_service_spec.rb
ee/spec/lib/gitlab/chat/responder_spec.rb
ee/spec/requests/api/boards_spec.rb
ee/spec/lib/audit/details_spec.rb
ee/spec/lib/ee/gitlab/ci/pipeline/chain/remove_unwanted_chat_jobs_spec.rb
ee/spec/workers/elastic_commit_indexer_worker_spec.rb
ee/spec/models/ee/ci/job_artifact_spec.rb
ee/spec/workers/build_finished_worker_spec.rb
ee/spec/services/path_locks/lock_service_spec.rb
ee/spec/services/projects/hashed_storage/migrate_repository_service_spec.rb
ee/spec/helpers/path_locks_helper_spec.rb
ee/spec/lib/ee/gitlab/auth/ldap/sync/external_users_spec.rb
ee/spec/tasks/gitlab/lfs/migrate_rake_spec.rb
ee/spec/features/issues/sub_nav_ee_spec.rb
ee/spec/lib/ee/gitlab/deltas_spec.rb
ee/spec/controllers/groups/milestones_controller_spec.rb
ee/spec/requests/projects/mirrors_controller_spec.rb
ee/spec/requests/api/license_spec.rb
ee/spec/services/merge_requests/build_service_spec.rb
ee/spec/services/path_locks/unlock_service_spec.rb
ee/spec/features/admin/admin_browses_log_spec.rb
ee/spec/services/wiki_pages/destroy_service_spec.rb
ee/spec/workers/clear_shared_runners_minutes_worker_spec.rb
ee/spec/requests/api/ldap_spec.rb
ee/spec/lib/ee/api/entities/geo_node_status_spec.rb
ee/spec/services/geo/node_update_service_spec.rb
ee/spec/controllers/users_controller_spec.rb
ee/spec/models/project_team_spec.rb
ee/spec/lib/ee/gitlab/ci/pipeline/chain/limit/activity_spec.rb
ee/spec/controllers/projects/pipelines_controller_spec.rb
ee/spec/controllers/groups/labels_controller_spec.rb
ee/spec/lib/ee/gitlab/auth/ldap/sync/admin_users_spec.rb
ee/spec/controllers/groups/variables_controller_spec.rb
ee/spec/services/groups/update_service_spec.rb
ee/spec/services/clear_namespace_shared_runners_minutes_service_spec.rb
ee/spec/controllers/admin/groups_controller_spec.rb
ee/spec/models/approval_spec.rb
ee/spec/presenters/audit_event_presenter_spec.rb
ee/spec/controllers/admin/licenses_controller_spec.rb
ee/spec/workers/ldap_group_sync_worker_spec.rb
ee/spec/lib/ee/gitlab/auth/ldap/sync/proxy_spec.rb
ee/spec/models/ee/protected_ref_spec.rb
ee/spec/serializers/group_child_entity_spec.rb
ee/spec/models/ee/user_spec.rb
ee/spec/services/groups/create_service_spec.rb
ee/spec/services/groups/destroy_service_spec.rb
ee/spec/services/wiki_pages/create_service_spec.rb
ee/spec/controllers/unsubscribes_controller_spec.rb
ee/spec/controllers/admin/users_controller_spec.rb
ee/spec/serializers/epic_entity_spec.rb
ee/spec/controllers/dashboard/milestones_controller_spec.rb
ee/spec/controllers/groups/settings/ci_cd_controller_spec.rb
ee/spec/controllers/profiles/slacks_controller_spec.rb
ee/spec/lib/gitlab/path_locks_finder_spec.rb
ee/spec/services/milestones/promote_service_spec.rb
ee/spec/controllers/admin/push_rules_controller_spec.rb
ee/spec/features/users/show_spec.rb
ee/spec/workers/remove_unreferenced_lfs_objects_worker_spec.rb
ee/spec/policies/issue_policy_spec.rb
ee/spec/uploaders/job_artifact_uploader_spec.rb
ee/spec/elastic_integration/elasticsearch_model_client_spec.rb
ee/spec/services/keys/create_service_spec.rb
ee/spec/lib/ee/gitlab/verify/uploads_spec.rb
ee/spec/controllers/groups/children_controller_spec.rb
ee/spec/controllers/groups/avatars_controller_spec.rb
ee/spec/models/ci/variable_spec.rb
ee/spec/controllers/dashboard/todos_controller_spec.rb
ee/spec/workers/project_update_repository_storage_worker_spec.rb
ee/spec/services/oauth2/logout_token_validation_service_spec.rb
ee/spec/lib/gitlab/ci/trace/http_io_spec.rb
ee/spec/models/historical_data_spec.rb
ee/spec/lib/gitlab/geo/database_tasks_spec.rb
ee/spec/models/ldap_group_link_spec.rb
ee/spec/lib/gitlab/mirror_spec.rb
ee/spec/policies/base_policy_spec.rb
ee/spec/lib/gitlab/kerberos/authentication_spec.rb
ee/spec/services/geo/repository_updated_event_store_spec.rb
ee/spec/controllers/profiles/billings_controller_spec.rb
ee/spec/services/ee/system_hooks_service_spec.rb
ee/spec/workers/create_github_webhook_worker_spec.rb
ee/spec/lib/ee/audit/group_changes_auditor_spec.rb
ee/spec/lib/gitlab/auth/ldap/user_spec.rb
ee/spec/workers/geo_repository_destroy_worker_spec.rb
ee/spec/controllers/dashboard/labels_controller_spec.rb
ee/spec/lib/gitlab/geo/oauth_session_spec.rb
ee/spec/services/keys/last_used_service_spec.rb
ee/spec/services/ci_cd/github_setup_service_spec.rb
Was resolved by https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/4890, just creating the issue for future reference!