Follow-up from "Geo - Repository verification on secondary node"

  • https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/4749#note_62126656

Maybe we should move this to Geo::RepositoryVerifySecondaryService. Wdyt?

We can also clean this up by asking the correct repository (project vs wiki) directly. Consider:

[19] pry(main)> Project.first.disk_path
=> "@hashed/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b"
[20] pry(main)> Project.first.wiki.disk_path
=> "@hashed/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b.wiki"

We should avoid generating the wiki path manually from the project path


  • https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/4749#note_61186939

For the counts to be accurate, we have to use FDW in the wiki case. Consider fdw_find_enabled_wikis


  • https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/4749#note_62177195

We'll have to be sure to ingest these into Elasticsearch as well. I'm fine with this now, but is there a reason why we wanted to break this out?

Edited Mar 23, 2018 by Brett Walker
Assignee Loading
Time tracking Loading