Linked issues are not automatically closed if "closes" is added via "Edit commit message" during merge
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Summary
We've been using gitlab for more than 5 years now an workflow I'm going to describe below used to work, but the behavior was broken in recent updates.
Steps to reproduce
- User creates a merge request from feature branch to default branch
- User creates commit message with extensive description and mentions related issue (just
group/project#123) - More commits being added over time
When the feature is complete and review is made, the person responsive for merge ticks three checkboxes: Delete source branch, Squash commits and Edit commit message. With Use an existing commit message dropdown, the aforementioned commit with extensive description is selected and the keyword closes is added before group/project#123.
After that the Merge button is pressed and group/project#123 is closed automatically.
But not anymore since, approximately v17.
What is the current bug behavior?
Current behavior is like closes keyword is ignored and mentioned issue is not closed automatically.
Project settings were not changed for years, commit is made to the default branch and Auto-close referenced issues on default branch is ticked.
What is the expected correct behavior?
Issue is automatically closed upon Merge button is pressed.
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Current User: git Using RVM: no Ruby Version: 3.2.5 Gem Version: 3.5.23 Bundler Version:2.5.11 Rake Version: 13.0.6 Redis Version: 7.0.15 Sidekiq Version:7.2.4 Go Version: unknown GitLab information Version: 17.7.0 Revision: eedc7c560c9 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 14.11 URL: https://git.acme.org HTTP Clone URL: https://git.acme.org/some-group/some-project.git SSH Clone URL: git@git.acme.org:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers: GitLab Shell Version: 14.39.0 Repository storages: - default: unix:/var/opt/gitlab/gitaly/gitaly.socket GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Gitaly - default Address: unix:/var/opt/gitlab/gitaly/gitaly.socket - default Version: 17.7.0 - default Git Version: 2.47.0
Results of GitLab application Check
Expand for output related to the GitLab application check
gitlab-rake gitlab:check SANITIZE=true Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 14.39.0 ? ... OK (14.39.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/gitlab-shell-check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes (cluster/worker) ... 1/1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Database config exists? ... yes Tables are truncated? ... skipped All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Cable config exists? ... yes Resque config exists? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... no Try fixing it: sudo chown -R git /var/opt/gitlab/gitlab-rails/uploads sudo find /var/opt/gitlab/gitlab-rails/uploads -type f -exec chmod 0644 {} ; sudo find /var/opt/gitlab/gitlab-rails/uploads -type d -not -path /var/opt/gitlab/gitlab-rails/uploads -exec chmod 0700 {} ; For more information see: doc/install/installation.md in section "GitLab" Please fix the error above and rerun the checks. Systemd unit files or init script exist? ... skipped (omnibus-gitlab has neither init script nor systemd units) Systemd unit files or init script up-to-date? ... skipped (omnibus-gitlab has neither init script nor systemd units) Projects have namespace: ... 41/1 ... yes 42/2 ... yes 42/3 ... yes 42/4 ... yes 42/5 ... yes 42/6 ... yes 42/7 ... yes 42/8 ... yes 42/9 ... yes 42/10 ... yes 42/11 ... yes 42/12 ... yes 42/13 ... yes 42/14 ... yes 42/15 ... yes 42/16 ... yes 42/17 ... yes 42/18 ... yes 42/19 ... yes 42/20 ... yes 42/21 ... yes 42/22 ... yes 42/23 ... yes 42/24 ... yes 42/25 ... yes 42/26 ... yes 42/27 ... yes 43/28 ... yes 43/29 ... yes 43/30 ... yes 43/31 ... yes 43/32 ... yes 43/33 ... yes 43/34 ... yes 43/35 ... yes 43/36 ... yes 43/37 ... yes 43/38 ... yes 43/39 ... yes 43/40 ... yes 43/41 ... yes 43/42 ... yes 43/43 ... yes 43/44 ... yes 43/45 ... yes 43/46 ... yes 43/47 ... yes 43/48 ... yes 43/49 ... yes 43/50 ... yes 43/51 ... yes 43/52 ... yes 43/53 ... yes 43/54 ... yes 43/55 ... yes 43/56 ... yes 43/57 ... yes 43/58 ... yes 44/59 ... yes 66/60 ... yes 66/61 ... yes 44/62 ... yes 49/63 ... yes 66/64 ... yes 44/65 ... yes 66/66 ... yes 44/67 ... yes 49/68 ... yes 67/69 ... yes 49/70 ... yes 66/71 ... yes 44/72 ... yes 44/73 ... yes 46/74 ... yes 70/75 ... yes 65/76 ... yes 44/77 ... yes 44/78 ... yes 44/79 ... yes 44/80 ... yes 66/81 ... yes 44/82 ... yes 44/83 ... yes 44/84 ... yes 44/85 ... yes 44/86 ... yes 67/87 ... yes 47/88 ... yes 63/89 ... yes 63/90 ... yes 45/91 ... yes 44/92 ... yes 44/93 ... yes 44/94 ... yes 44/95 ... yes 44/96 ... yes 44/97 ... yes 44/98 ... yes 44/99 ... yes 44/100 ... yes 66/101 ... yes 44/102 ... yes 49/103 ... yes 48/104 ... yes 44/105 ... yes 44/106 ... yes 44/107 ... yes 44/108 ... yes 44/109 ... yes 44/110 ... yes 44/111 ... yes 44/112 ... yes 44/113 ... yes 44/114 ... yes 70/115 ... yes 49/116 ... yes 44/117 ... yes 44/118 ... yes 44/119 ... yes 44/120 ... yes 66/121 ... yes 44/122 ... yes 46/123 ... yes 44/124 ... yes 45/125 ... yes 43/126 ... yes 44/127 ... yes 67/128 ... yes 65/129 ... yes 49/130 ... yes 49/131 ... yes 49/132 ... yes 49/133 ... yes 70/134 ... yes 65/135 ... yes 67/136 ... yes 66/137 ... yes 49/138 ... yes 65/139 ... yes 67/140 ... yes 44/141 ... yes 66/142 ... yes 67/143 ... yes 44/144 ... yes 44/145 ... yes 44/146 ... yes 66/147 ... yes 44/148 ... yes 66/149 ... yes 44/150 ... yes 66/151 ... yes 44/152 ... yes 66/153 ... yes 44/154 ... yes 67/155 ... yes 44/156 ... yes 50/157 ... yes 50/158 ... yes 50/159 ... yes 44/160 ... yes 66/161 ... yes 70/162 ... yes 67/163 ... yes 44/164 ... yes 46/165 ... yes 46/166 ... yes 48/167 ... yes 44/168 ... yes 49/169 ... yes 67/170 ... yes 65/171 ... yes 67/172 ... yes 66/173 ... yes 51/174 ... yes 44/175 ... yes 44/176 ... yes 44/177 ... yes 44/178 ... yes 44/179 ... yes 44/180 ... yes 44/181 ... yes 70/182 ... yes 67/183 ... yes 65/184 ... yes 49/185 ... yes 60/186 ... yes 49/187 ... yes 47/188 ... yes 44/189 ... yes 67/190 ... yes 52/191 ... yes 52/194 ... yes 70/195 ... yes 67/196 ... yes 49/197 ... yes 44/198 ... yes 42/199 ... yes 48/200 ... yes 49/201 ... yes 42/202 ... yes 41/203 ... yes 41/204 ... yes 41/205 ... yes 44/207 ... yes 44/208 ... yes 44/209 ... yes 44/210 ... yes 70/212 ... yes 67/213 ... yes 44/214 ... yes 51/215 ... yes 56/216 ... yes 56/217 ... yes 58/218 ... yes 49/219 ... yes 49/220 ... yes 58/221 ... yes 42/222 ... yes 45/223 ... yes 44/224 ... yes 49/225 ... yes 48/226 ... yes 49/227 ... yes 57/228 ... yes 57/229 ... yes 59/230 ... yes 60/232 ... yes 42/233 ... yes 42/234 ... yes 42/235 ... yes 60/236 ... yes 44/237 ... yes 43/238 ... yes 66/239 ... yes 67/240 ... yes 44/241 ... yes 51/242 ... yes 44/243 ... yes 6/244 ... yes 35/245 ... yes 35/246 ... yes 8/247 ... yes 44/248 ... yes 6/249 ... yes 66/250 ... yes 35/251 ... yes 66/252 ... yes 67/253 ... yes 67/254 ... yes 66/255 ... yes 63/256 ... yes 63/257 ... yes 63/258 ... yes 63/259 ... yes 66/260 ... yes 44/261 ... yes 46/262 ... yes 63/263 ... yes 57/264 ... yes 63/265 ... yes 65/266 ... yes 63/267 ... yes 67/268 ... yes 67/269 ... yes 70/270 ... yes 46/271 ... yes 70/272 ... yes 67/273 ... yes 60/274 ... yes 44/275 ... yes 70/276 ... yes 66/277 ... yes 67/278 ... yes 41/279 ... yes 66/280 ... yes 70/281 ... yes 67/282 ... yes 44/283 ... yes 66/284 ... yes 70/285 ... yes 67/287 ... yes 41/288 ... yes 66/289 ... yes 70/290 ... yes 67/291 ... yes 70/292 ... yes 66/293 ... yes 41/294 ... yes 70/295 ... yes 66/296 ... yes 70/297 ... yes 67/298 ... yes 66/299 ... yes 70/300 ... yes 67/301 ... yes 102/302 ... yes 66/303 ... yes 44/304 ... yes 44/305 ... yes 67/306 ... yes 57/308 ... yes 66/309 ... yes 67/310 ... yes 48/311 ... yes 66/312 ... yes 67/313 ... yes 66/314 ... yes 70/315 ... yes 67/316 ... yes 66/318 ... yes 6/319 ... yes 80/320 ... yes 6/321 ... yes 70/322 ... yes 66/323 ... yes 63/325 ... yes 74/326 ... yes 6/327 ... yes 52/328 ... yes 78/329 ... yes 75/330 ... yes 79/332 ... yes 79/333 ... yes 79/334 ... yes 79/335 ... yes 79/336 ... yes 79/337 ... yes 79/338 ... yes 79/339 ... yes 80/340 ... yes 81/341 ... yes 81/342 ... yes 81/343 ... yes 8/344 ... yes 8/345 ... yes 6/346 ... yes 8/347 ... yes 60/348 ... yes 60/349 ... yes 60/350 ... yes 67/351 ... yes 81/352 ... yes 41/353 ... yes 57/354 ... yes 44/355 ... yes 63/356 ... yes 67/357 ... yes 43/358 ... yes 82/360 ... yes 82/361 ... yes 82/362 ... yes 6/363 ... yes 6/364 ... yes 57/365 ... yes 6/366 ... yes 67/367 ... yes 82/368 ... yes 41/370 ... yes 6/371 ... yes 63/372 ... yes 6/373 ... yes 63/374 ... yes 63/375 ... yes 63/376 ... yes 60/377 ... yes 86/378 ... yes 87/379 ... yes 65/380 ... yes 65/381 ... yes 65/382 ... yes 65/383 ... yes 89/384 ... yes 67/385 ... yes 66/386 ... yes 66/387 ... yes 67/389 ... yes 88/390 ... yes 63/392 ... yes 91/393 ... yes 91/394 ... yes 91/395 ... yes 91/396 ... yes 91/397 ... yes 91/398 ... yes 91/399 ... yes 70/400 ... yes 67/401 ... yes 80/402 ... yes 63/403 ... yes 57/404 ... yes 65/405 ... yes 65/406 ... yes 63/408 ... yes 8/409 ... yes 41/410 ... yes 66/411 ... yes 90/412 ... yes 71/413 ... yes 71/414 ... yes 71/415 ... yes 71/416 ... yes 44/417 ... yes 70/420 ... yes 88/421 ... yes 66/422 ... yes 41/423 ... yes 89/424 ... yes 88/425 ... yes 88/426 ... yes 63/427 ... yes 96/429 ... yes 96/430 ... yes 88/433 ... yes 41/434 ... yes 88/435 ... yes 98/437 ... yes 98/438 ... yes 67/441 ... yes 88/442 ... yes 99/443 ... yes 89/444 ... yes 88/445 ... yes 71/446 ... yes 71/447 ... yes 6/448 ... yes 88/449 ... yes 88/450 ... yes 965/451 ... yes 103/452 ... yes 66/456 ... yes 104/457 ... yes 71/458 ... yes 88/459 ... yes 66/460 ... yes 8/461 ... yes 104/463 ... yes 74/464 ... yes 57/465 ... yes 66/466 ... yes 96/468 ... yes 88/469 ... yes 88/470 ... yes 29/471 ... yes 88/474 ... yes 88/475 ... yes 88/476 ... yes 66/477 ... yes 41/480 ... yes 113/481 ... yes 67/482 ... yes 70/483 ... yes 6/484 ... yes 6/485 ... yes 96/486 ... yes 113/487 ... yes 96/488 ... yes 96/489 ... yes 6/490 ... yes 57/491 ... yes 88/492 ... yes 88/493 ... yes 44/494 ... yes 88/495 ... yes 60/496 ... yes 63/497 ... yes 65/498 ... yes 65/499 ... yes 65/500 ... yes 65/501 ... yes 65/502 ... yes 66/503 ... yes 88/504 ... yes 70/505 ... yes 66/506 ... yes 96/507 ... yes 65/508 ... yes 49/509 ... yes 8/510 ... yes 6/511 ... yes 113/512 ... yes 65/513 ... yes 65/514 ... yes 43/515 ... yes 6/516 ... yes 70/517 ... yes 66/518 ... yes 66/519 ... yes 66/520 ... yes 88/521 ... yes 66/522 ... yes 71/523 ... yes 66/524 ... yes 66/525 ... yes 66/526 ... yes 89/527 ... yes 88/528 ... yes 66/529 ... yes 43/530 ... yes 66/531 ... yes 122/532 ... yes 122/533 ... yes 67/534 ... yes 96/536 ... yes 60/537 ... yes 122/538 ... yes 122/539 ... yes 122/540 ... yes 49/541 ... yes 122/542 ... yes 88/543 ... yes 66/544 ... yes 43/545 ... yes 67/546 ... yes 70/547 ... yes 88/548 ... yes 6/549 ... yes 74/550 ... yes 67/551 ... yes 88/552 ... yes 88/553 ... yes 6/554 ... yes 6/555 ... yes 124/556 ... yes 88/557 ... yes 66/558 ... yes 70/559 ... yes 67/560 ... yes 57/561 ... yes 122/562 ... yes 88/563 ... yes 88/564 ... yes 122/565 ... yes 44/567 ... yes 126/568 ... yes 126/569 ... yes 126/570 ... yes 126/571 ... yes 44/572 ... yes 126/573 ... yes 126/574 ... yes 126/575 ... yes 126/576 ... yes 126/577 ... yes 126/578 ... yes 126/579 ... yes 126/580 ... yes 126/581 ... yes 126/582 ... yes 126/583 ... yes 126/584 ... yes 126/585 ... yes 126/586 ... yes 126/587 ... yes 126/588 ... yes 126/589 ... yes 126/590 ... yes 126/591 ... yes 126/592 ... yes 126/593 ... yes 126/594 ... yes 126/595 ... yes 126/596 ... yes 126/597 ... yes 126/598 ... yes 126/599 ... yes 126/600 ... yes 126/601 ... yes 126/602 ... yes 126/603 ... yes 126/604 ... yes 126/605 ... yes 126/606 ... yes 126/607 ... yes 126/608 ... yes 126/609 ... yes 126/610 ... yes 126/611 ... yes 75/612 ... yes 71/613 ... yes 71/614 ... yes 71/615 ... yes 71/616 ... yes 126/617 ... yes 88/618 ... yes 126/619 ... yes 99/620 ... yes 88/621 ... yes 88/622 ... yes 88/623 ... yes 88/624 ... yes 88/625 ... yes 133/626 ... yes 88/627 ... yes 82/628 ... yes 6/629 ... yes 35/630 ... yes 35/631 ... yes 126/632 ... yes 36/633 ... yes 6/634 ... yes 126/635 ... yes 124/636 ... yes 124/637 ... yes 124/638 ... yes 124/639 ... yes 124/640 ... yes 124/641 ... yes 124/642 ... yes 67/643 ... yes 124/644 ... yes 124/645 ... yes 131/646 ... yes 88/647 ... yes 88/648 ... yes 124/649 ... yes 124/650 ... yes 131/652 ... yes 126/653 ... yes 99/654 ... yes 88/655 ... yes 133/657 ... yes 133/658 ... yes 66/659 ... yes 88/660 ... yes 88/661 ... yes 71/662 ... yes 6/663 ... yes 124/664 ... yes 88/665 ... yes 6/666 ... yes 6/667 ... yes 6/668 ... yes 6/669 ... yes 6/670 ... yes 6/671 ... yes 65/673 ... yes 126/674 ... yes 88/675 ... yes 88/676 ... yes 124/677 ... yes 88/678 ... yes 88/679 ... yes 124/680 ... yes 88/681 ... yes 88/682 ... yes 88/683 ... yes 65/684 ... yes 60/685 ... yes 43/686 ... yes 66/687 ... yes 8/688 ... yes 43/689 ... yes 67/690 ... yes 71/691 ... yes 88/692 ... yes 88/693 ... yes 75/694 ... yes 79/695 ... yes 44/696 ... yes 44/697 ... yes 88/698 ... yes 88/699 ... yes 71/700 ... yes 88/701 ... yes 88/702 ... yes 57/703 ... yes 820/705 ... yes 821/706 ... yes 819/708 ... yes 820/709 ... yes 822/710 ... yes 822/711 ... yes 822/712 ... yes 819/713 ... yes 88/714 ... yes 836/715 ... yes 88/716 ... yes 63/718 ... yes 88/719 ... yes 35/720 ... yes 43/721 ... yes 88/722 ... yes 41/723 ... yes 88/724 ... yes 822/725 ... yes 822/726 ... yes 851/727 ... yes 43/728 ... yes 71/730 ... yes 819/731 ... yes 860/732 ... yes 860/733 ... yes 115/734 ... yes 88/735 ... yes 88/737 ... yes 860/738 ... yes 88/739 ... yes 88/740 ... yes 822/741 ... yes 851/742 ... yes 88/743 ... yes 88/744 ... yes 88/745 ... yes 88/746 ... yes 877/747 ... yes 877/748 ... yes 6/749 ... yes 88/750 ... yes 35/752 ... yes 882/753 ... yes 89/754 ... yes 88/755 ... yes 1093/756 ... yes 821/758 ... yes 126/759 ... yes 88/760 ... yes 133/761 ... yes 88/762 ... yes 67/764 ... yes 66/765 ... yes 6/767 ... yes 63/768 ... yes 882/769 ... yes 819/770 ... yes 882/771 ... yes 88/772 ... yes 88/773 ... yes 60/774 ... yes 88/775 ... yes 882/776 ... yes 60/777 ... yes 912/778 ... yes 912/779 ... yes 126/780 ... yes 877/781 ... yes 66/782 ... yes 41/784 ... yes 71/785 ... yes 912/786 ... yes 921/787 ... yes 921/788 ... yes 921/789 ... yes 926/790 ... yes 67/791 ... yes 63/792 ... yes 930/793 ... yes 930/794 ... yes 88/795 ... yes 934/796 ... yes 63/797 ... yes 88/798 ... yes 35/799 ... yes 31/800 ... yes 31/801 ... yes 88/802 ... yes 1114/804 ... yes 819/805 ... yes 877/806 ... yes 819/807 ... yes 819/808 ... yes 88/809 ... yes 41/810 ... yes 88/811 ... yes 88/812 ... yes 31/815 ... yes 82/816 ... yes 1087/817 ... yes 819/818 ... yes 6/819 ... yes 35/820 ... yes 954/821 ... yes 82/822 ... yes 41/823 ... yes 882/824 ... yes 821/826 ... yes 35/827 ... yes 972/828 ... yes 88/829 ... yes 877/830 ... yes 972/831 ... yes 972/835 ... yes 821/836 ... yes 972/838 ... yes 972/841 ... yes 41/842 ... yes 88/844 ... yes 819/845 ... yes 6/846 ... yes 88/847 ... yes 995/848 ... yes 994/849 ... yes 995/850 ... yes 996/851 ... yes 996/852 ... yes 1005/853 ... yes 1005/854 ... yes 1008/855 ... yes 1008/856 ... yes 997/857 ... yes 997/858 ... yes 999/859 ... yes 999/860 ... yes 998/861 ... yes 998/862 ... yes 1018/864 ... yes 1018/865 ... yes 1018/866 ... yes 1018/867 ... yes 1018/868 ... yes 1018/869 ... yes 1018/870 ... yes 1049/871 ... yes 1018/872 ... yes 1018/873 ... yes 1018/874 ... yes 1018/875 ... yes 1018/876 ... yes 1018/877 ... yes 1018/878 ... yes 1018/879 ... yes 1049/880 ... yes 1049/881 ... yes 972/882 ... yes 1049/884 ... yes 1049/885 ... yes 1049/887 ... yes 1050/893 ... yes 1050/894 ... yes 1050/895 ... yes 1050/896 ... yes 1050/897 ... yes 1050/898 ... yes 1050/899 ... yes 1050/900 ... yes 1050/901 ... yes 1050/902 ... yes 1050/903 ... yes 1050/904 ... yes 1050/905 ... yes 1050/906 ... yes 1050/907 ... yes 1050/908 ... yes 1050/909 ... yes 1050/910 ... yes 1050/911 ... yes 1050/912 ... yes 1050/913 ... yes 1050/914 ... yes 972/915 ... yes 972/916 ... yes 8/917 ... yes 8/919 ... yes 972/920 ... yes 819/921 ... yes 972/922 ... yes 88/923 ... yes 41/924 ... yes 88/925 ... yes 88/926 ... yes 88/927 ... yes 88/928 ... yes 88/929 ... yes 126/930 ... yes 1049/931 ... yes 1050/932 ... yes 1093/934 ... yes 67/936 ... yes 67/937 ... yes 877/938 ... yes 88/939 ... yes 819/940 ... yes 972/941 ... yes 1102/942 ... yes 1102/943 ... yes 1102/945 ... yes 1102/946 ... yes 1050/947 ... yes 1018/948 ... yes 8/949 ... yes 972/950 ... yes 972/951 ... yes 44/952 ... yes 1114/953 ... yes 1114/954 ... yes 1114/955 ... yes 1119/957 ... yes 1119/958 ... yes 1119/959 ... yes 1119/960 ... yes 1124/961 ... yes 1124/962 ... yes 1124/963 ... yes 1129/965 ... yes 1129/966 ... yes 1132/967 ... yes 1132/968 ... yes 1132/969 ... yes 1087/970 ... yes 819/971 ... yes Redis version >= 6.2.14? ... yes Ruby version >= 3.0.6 ? ... yes (3.2.5) Git user has default SSH configuration? ... yes Active users: ... 44 Is authorized keys file accessible? ... yes GitLab configured to store new projects in hashed storage? ... yes All projects are in hashed storage? ... yes
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished
We're using official docker image and current version is v17.7.0