Gitlab Runner chart: new registration workflow not working when providing the token via secret

Summary

The new registration workflow is not working when providing the token via secret. Deprecated flags from the old workflow are handed to the registration command.

This is because "isAuthToken" is false in our case, as it only looks at the token provided via Values. https://gitlab.com/gitlab-org/charts/gitlab-runner/-/blob/main/templates/_helpers.tpl#L123 But we use a secret to pass the token.

Apparently a solution for this existed 5 months ago (also checking for Tokens provided via secret), but was removed for some reason? gitlab-org/charts/gitlab-runner!489 (diffs)

Edited by Luis Fittkau