Remove sidekiq_queues.yml and all_queues.yml from GitLab Rails

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Work on this issue
• Close this issue

The config/sidekiq_queues.yml and app/all_queues.yml and ee/app/all_queues.yml files were important queue definitions for queue selector. Since we've removed queue selector in https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/2220 on %17.0, we can also clean up these files along with the static analysis checks that keep these files up to date.

We should be able to remove these at any release version as it wouldn't break any GitLab functionality, which is why it wasn't bundled with the queue selector removal.

• Remove config/sidekiq_queues.yml from Rails app.

  We no longer rely on the weights assigned to these queues, so we should be safe to remove this.

  This is used by:

  • rake gitlab:sidekiq:sidekiq_queues_yml similarly as all_queues.yml
  • Pre-push lefthook https://gitlab.com/gitlab-org/gitlab/-/blob/8197b3f957111f748d5ac75be367176faa7c0d09/lefthook.yml#L55-55

• ❓ Possibly remove app/all_queues.yml and ee/app/all_queues.yml from Rails app.

  It should be safe to remove since routing rules don't depend on these at all. However, there is a slight concern whether people use that file as a reference to figure out the worker attributes to manage routing rules, which is also mentioned in https://docs.gitlab.com/ee/administration/sidekiq/processing_specific_job_classes.html#list-of-available-job-classes. Without the file, self-managed users would have to deduce the worker's class by themselves or run something like Gitlab::SidekiqConfig::Worker.new(AuthorizedProjectsWorker, ee: false).to_yaml. Some discussions surrounding whether we can remove these yamls !142577 (comment 1744528020).

  They are used by:

  • rake gitlab:sidekiq:all_queues_yml to sync all worker metadatas https://gitlab.com/gitlab-org/gitlab/-/blob/8197b3f957111f748d5ac75be367176faa7c0d09/lib/tasks/gitlab/sidekiq.rake#L36-76. Static analysis job in CI runs this check.
  • Pre-push lefthook https://gitlab.com/gitlab-org/gitlab/-/blob/8197b3f957111f748d5ac75be367176faa7c0d09/lefthook.yml#L55-55