Skip to content

Probable double escaping using "Find file" in Code / Repository, on a branch name with special characters

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Summary

Using "Find file" fonctionnality on a branch with a "#" sharp in the name, results in a 404 page.

Steps to reproduce

What is the current bug behavior?

404 error

What is the expected correct behavior?

Should go to the page

Relevant logs and/or screenshots

View of the gitlab before the search: firefox_YZTdn5wUHVXX

404 error with Url : firefox_Dpkjq2Pz6L

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:         Ubuntu 22.04
Current User:   git
Using RVM:      no
Ruby Version:   3.2.5
Gem Version:    3.5.23
Bundler Version:2.5.11
Rake Version:   13.0.6
Redis Version:  7.0.15
Sidekiq Version:7.2.4
Go Version:     unknown

GitLab information
Version:        17.7.0
Revision:       eedc7c560c9
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     PostgreSQL
DB Version:     14.11
URL:            https://areal.topkapi.net/gitlab
HTTP Clone URL: https://areal.topkapi.net/gitlab/some-group/some-project.git
SSH Clone URL:  git@gitlab.areal.local:some-group/some-project.git
Using LDAP:     no
Using Omniauth: yes
Omniauth Providers: saml

GitLab Shell
Version:        14.39.0
Repository storages:
- default:      unix:/var/opt/gitlab/gitaly/gitaly.socket
GitLab Shell path:              /opt/gitlab/embedded/service/gitlab-shell

Gitaly
- default Address:      unix:/var/opt/gitlab/gitaly/gitaly.socket
- default Version:      17.7.0
- default Git Version:  2.47.0

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab subtasks ...


Checking GitLab Shell ...


GitLab Shell: ... GitLab Shell version >= 14.39.0 ? ... OK (14.39.0)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/gitlab-shell-check
Internal API available: OK
Redis available via internal API: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Gitaly ...


Gitaly: ... default ... OK


Checking Gitaly ... Finished


Checking Sidekiq ...


Sidekiq: ... Running? ... yes
Number of Sidekiq processes (cluster/worker) ... 1/1


Checking Sidekiq ... Finished


Checking Incoming Email ...


Incoming Email: ... Reply by email is disabled in config/gitlab.yml


Checking Incoming Email ... Finished


Checking LDAP ...


LDAP: ... LDAP is disabled in config/gitlab.yml


Checking LDAP ... Finished


Checking GitLab App ...


Database config exists? ... yes
Tables are truncated? ... skipped
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Cable config exists? ... yes
Resque config exists? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Systemd unit files or init script exist? ... skipped (omnibus-gitlab has neither init script nor systemd units)
Systemd unit files or init script up-to-date? ... skipped (omnibus-gitlab has neither init script nor systemd units)
Projects have namespace: ...
24/1 ... yes
6/2 ... yes
20/5 ... yes
20/6 ... yes
20/9 ... yes
20/10 ... yes
20/11 ... yes
20/12 ... yes
20/14 ... yes
20/17 ... yes
20/19 ... yes
6/20 ... yes
37/21 ... yes
23/23 ... yes
20/24 ... yes
5/27 ... yes
23/28 ... yes
45/29 ... yes
20/30 ... yes
23/31 ... yes
32/32 ... yes
2/33 ... yes
52/34 ... yes
4/35 ... yes
45/36 ... yes
45/39 ... yes
59/40 ... yes
23/41 ... yes
45/42 ... yes
23/43 ... yes
23/44 ... yes
23/45 ... yes
45/46 ... yes
2/47 ... yes
45/48 ... yes
45/49 ... yes
45/50 ... yes
23/51 ... yes
45/52 ... yes
45/53 ... yes
23/55 ... yes
14/56 ... yes
117/57 ... yes
23/58 ... yes
23/59 ... yes
2/60 ... yes
57/61 ... yes
127/62 ... yes
45/63 ... yes
45/64 ... yes
23/65 ... yes
127/66 ... yes
127/67 ... yes
127/68 ... yes
23/69 ... yes
23/70 ... yes
14/72 ... yes
23/73 ... yes
Redis version >= 6.2.14? ... yes
Ruby version >= 3.0.6 ? ... yes (3.2.5)
Git user has default SSH configuration? ... yes
Active users: ... 54
Is authorized keys file accessible? ... yes
GitLab configured to store new projects in hashed storage? ... yes
All projects are in hashed storage? ... yes


Checking GitLab App ... Finished


Checking GitLab subtasks ... Finished

My team members told me it was ok with 16.0.5 so it is possibly a regression.

Edited by 🤖 GitLab Bot 🤖