Database column changes to rename Secret Push Protection - M

Overview

Related to #462504 (closed)

Since we are renaming pre-receive secret detection to secret push protection, we should update the code to reflect this. This includes renaming columns, policy checks, and other places. This issue addresses the "release M" steps, which are 1. Add the regular migration, 2. Ignore the column, and 3. Add a post-deployment migration. Issue #512996 (closed) addresses the "M+1" steps for renaming a database column.

Proposal

We need to rename these database columns:

Database Columns

• Rename pre_receive_secret_detection_enabled to secret_push_protection_allowed in application_settings table.
• Rename pre_receive_secret_detection_enabled to secret_push_protection_enabled in project_security_settings table.

Follow the database migration steps to rename the columns. In 17.9 we will complete the "release M" steps, which are 1. Add the regular migration, 2. Ignore the column, and 3. Add a post-deployment migration. In 17.10, we will complete the "release M+1" step, which is Remove the ignore rule.

Considerations

• We may need to double check how this affects the metric definition added in !156076 (merged).