Remove default_max_hours_before_termination and max_hours_before_termination_limit from agent_config proto definition
Description
As part of the deprecation process of the old termination logic, default_max_hours_before_termination and max_hours_before_termination_limit would need to be removed from the agent_config proto definition.
This is a breaking change on the agent_config file as there is strict validation on the schema
The result of failing the schema validation prevents us from saving the config file. We would need to broadcast this removal as well, preferably here (link 18.0 broadcast) due to more visibility than agent release notes (also there as well on the MR that takes out the field)
NOTE:
I originally wanted to first deprecate them, but AFAIK this schema is only used within the agent/KAS, so there is little benefit to this IMO since the agent notes are not necessarily consulted (I am open to marking them as deprecated before 18.0 though)
Acceptance Criteria
-
default_max_hours_before_terminationandmax_hours_before_termination_limitremoved from the agent proto definition
Technical Requirements
Design Requirements
Impact Assessment
- agent config files that have
default_max_hours_before_terminationandmax_hours_before_termination_limitwill be invalid, users need to manually fix it.
Agent team had this command in the GLab CLI to help users find agents with deprecated configs to aid removal. If we want to be more detailed an limit breaking effect we might want something similar maybe?
IDK, would need more consensus on this on how much impact this might have if we remove it alone.
Update: We will be just taking the fields out, and expect users to check release notes.