Review and Update `spinner-deprecated` Mixin
File:
app/assets/stylesheets/framework/spinner.scss
Feedback:
- Thought 1: We have spinner-specific colors.
-
Thought 2: Is this mixin used anywhere, or can it now be deleted?
– Dan MH
Proposal:
- Investigate the usage of
spinner-deprecatedmixin across the codebase. - If the mixin is still used:
- Replace
$gray-700andvar(--gl-icon-color-subtle)with spinner-specific colors from the design system.
- Replace
- If the mixin is no longer in use:
- Remove the
spinner-deprecatedmixin fromapp/assets/stylesheets/framework/spinner.scss.
- Remove the
Steps:
- Search for all occurrences of the
spinner-deprecatedmixin. - Verify if it aligns with current design standards or can be safely removed.
- Create a merge request to update or remove the mixin as appropriate.
References:
- Comment by Dan MH
Impact:
- Ensures the codebase stays aligned with the design system.
- Reduces reliance on deprecated or unused code.
Next Steps:
- Conduct a usage audit of
spinner-deprecated. - Update or remove the mixin based on findings.
Edited by James Rushford