Review and Update `spinner-deprecated` Mixin

File:

app/assets/stylesheets/framework/spinner.scss

Feedback:

  • Thought 1: We have spinner-specific colors.
  • Thought 2: Is this mixin used anywhere, or can it now be deleted?
    – Dan MH

Proposal:

  1. Investigate the usage of spinner-deprecated mixin across the codebase.
  2. If the mixin is still used:
    • Replace $gray-700 and var(--gl-icon-color-subtle) with spinner-specific colors from the design system.
  3. If the mixin is no longer in use:
    • Remove the spinner-deprecated mixin from app/assets/stylesheets/framework/spinner.scss.

Steps:

  1. Search for all occurrences of the spinner-deprecated mixin.
  2. Verify if it aligns with current design standards or can be safely removed.
  3. Create a merge request to update or remove the mixin as appropriate.

References:

  • Comment by Dan MH

Impact:

  • Ensures the codebase stays aligned with the design system.
  • Reduces reliance on deprecated or unused code.

Next Steps:

  • Conduct a usage audit of spinner-deprecated.
  • Update or remove the mixin based on findings.
Edited by James Rushford