Skip to content

PostReceive worker does not follow Worker suffix naming convention

Our PostReceive worker should be renamed PostReceiveWorker, including the EE module.

https://gitlab.com/gitlab-org/gitlab/-/blob/bbdcb9f25eedb19f5e1c8cd403d21261485f2182/app/workers/post_receive.rb

We need to follow our guide on renaming workers for this https://docs.gitlab.com/ee/development/sidekiq/compatibility_across_updates.html#renaming-worker-classes

List of workers that do not follow the convention
=> ["ee/app/workers/ee/post_receive.rb",
 "ee/app/workers/incident_management/oncall_rotations/persist_all_rotations_shifts_job.rb",
 "ee/app/workers/incident_management/oncall_rotations/persist_shifts_job.rb",
 "ee/app/workers/vulnerability_external_issue_links/update_vulnerability_read.rb",
 "ee/app/workers/work_items/rolledup_dates/bulk_update_handler.rb",
 "ee/app/workers/work_items/rolledup_dates/update_milestone_related_work_item_dates_event_handler.rb",
 "ee/app/workers/work_items/rolledup_dates/update_rolledup_dates_event_handler.rb",
 "app/workers/ci/resource_groups/assign_resource_from_resource_group_worker_v2.rb",
 "app/workers/gitlab/import/advance_stage.rb",
 "app/workers/gitlab/import/stuck_import_job.rb",
 "app/workers/incident_management/process_alert_worker_v2.rb",
 "app/workers/post_receive.rb"]
Edited by Joe Woodward