[SPIKE] Identify how and where the current merge request approval settings are used
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
We need to identify all the locations where the existing merge request approval settings are used
This includes:
- Prevent approval by author ->
project.merge_requests_author_approval
- Prevent approvals by users who add commits ->
project.merge_requests_disable_committers_approval
- Prevent editing approval rules in merge requests ->
project.disable_overriding_approvers_per_merge_request
- Require user re-authentication (Password or SAML) to approve -> [
project.require_password_to_approve
,project.project_settings.require_reauthentication_to_approve
- When a commit is added:
a. Keep approvals
b. Remove all approvals ->
project.reset_approvals_on_push
c. Remove approvals by Code Owners if their files changed ->project.project_settings.selective_code_owner_removals
Each of these settings need to be investigated. Once we identify how these settings are applied we need to create an issue for each place where we need to update the logic. This may be 1 issue per setting but could also be many more if we find multiple places where that setting is used.
Edited by 🤖 GitLab Bot 🤖