gitlab:git:fsck rake task checks archived repositories by default, change to skip
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Release notes
Problem to solve
Recent versions of git now report more fsck errors, see gitaly#5641 for details.
This means that when a customer has enabled the setting
- Enable repository checks for all projects - https://docs.gitlab.com/ee/administration/repository_checks.html#enable-repository-checks-for-all-projects
the GitLab administrators will receive email alerts every week regarding these.
This causes noise and may obscure new alerts from being seen.
Proposal
I propose modifying the default behavior of the gitlab:git:fsck rake task to skip archived projects.
However, we also should adding an option to include archived projects if needed.
e.g.
1. Update the `gitlab:git:fsck` rake task to skip archived projects by default.
2. Add a new option (e.g., `INCLUDE_ARCHIVED=true`) to allow checking of archived projects when explicitly specified.Benefits
- Reduced processing time and resource usage for instances with many archived projects.
- Maintains flexibility for administrators who need to check archived projects.
- Aligns with the general expectation that archived projects are low-maintenance.
Additional Context
This change would be particularly beneficial for large GitLab instances with a significant number of archived projects, as it would reduce the overall runtime of maintenance tasks.