Skip to content

Internal events monitor does not render the `label` column correctly.

Summary

The Internal Events Monitor does not render the value for additional_attributes[:label] correctly on the snowplow table.

Steps to reproduce

  1. Add a new internal tracking event with additional_properties: label
  2. Start the internal event monitor with rails runner scripts/internal_events/monitor.rb <action>
  3. Trigger the event with track_internal_event, make sure to set a value for additional_attributes: label

Note: I haven't checked but this issue might also apply to the property and value fields.

Example Project Merge Request

!172017 (merged)

What is the current bug behavior?

The snowplow table in the terminal captures the event but without the label property.

What is the expected correct behavior?

The snowplow table in the terminal should capture the event along with the label property.

Possible fixes

In a quick investigation, it seems like https://gitlab.com/gitlab-org/gitlab/blob/b453eae245b74b78fda39eb40dc6f1692fb0b28c/scripts/internal_events/monitor.rb#L119 is using the se_label key while the actual value is stored in label.

I'm not too aware of the context behind this but maybe we can coalesce the value from either keys?

Edited by Shane Maglangit