Approval list is empty and cannot be merged
Summary
The approval list is empty and the MR cannot be merged. I believe this happens because of some oddities with the way approvals work and group membership. If a project belongs to a subgroup, and no one was explicitly added to the subgroup, and that subgroup is used as the approval list, and the creator of the subgroup creates an MR, there is no one else to approve the MR.
In my opinion this is an overall issue with the odd way groups are done in GitLab. Group membership should not flow down into subgroups. It should be explicitly done. Currently members of parent groups show up in sub groups, but since they are not explicitly added, they don't get added to approval lists and whatever else checks for explicit membership. This is extremely confusing.
Steps to reproduce
Create a group Create a subgroup Don't add anyone to the subgroup Create a project in the subgroup Turn on approvals for the project with the subgroup being the approval list
Example Project
What is the current bug behavior?
The approval list is empty and the merge button is greyed out.
What is the expected correct behavior?
The merge button should be green given I (the user in this case) is at least a Master (in this case I'm an Owner).
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com