Skip to content

Follow-up from "Limit selected reviewers to only the selected reviewers eligible for a given rule"

The following discussion from !169669 (merged) should be addressed:

  • @snachnolkar started a discussion: (+2 comments)

    suggestion (non-blocking): I find this a bit confusing to read because we are naming the local const as visibleReviewers which is also the name of the prop passed to this component. Is there a more appropriate naming that can help distinguish between the two?

    Maybe the prop name could be updated from visibleReviewers to eligibleReviewers since that is not the actual list of reviewers which is visible. WDYT?