Update LegacyGithubImport to be solely for Gitea

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Context

LegacyGithubImport::Importer and components under LegacyGithubImport namespace used to be for Gitea and GitHub imports. Today, GitHub imports almost entirely use components in the GithubImport namespace, with the exception of LegacyGithubImport::ProjectCreator to create just the project. On master right now, the specs for LegacyGithubImport::Importer (permalink) have shared examples that were once used to test imports from Gitea and GitHub, but the context for GitHub has since been removed from the specs, but not the importer itself.

Problem

The LegacyGithubImport::Importer, the LegacyGithubImport formatter classes, and their specs all still contain branching logic for GitHub imports, despite no longer being relevant. It adds unnecessary complexity to the importer, and makes maintaining it more difficult despite it being one of the simplest importers in GitLab.

Proposed solution

We should remove all branching logic supporting GitHub imports from LegacyGithubImport components (except for LegacyGithubImport::ProjectCreator) since they're only ever used for Gitea imports anyway. Anything that's behind a check like unless project.gitea_import? is a good place to begin looking for what can be removed.

Questions

It makes sense to rename LegacyGithubImport to GiteaImport along with this change, but what does that mean for LegacyGithubImport::ProjectCreator since it's still used by the current GitHub import process? Should LegacyGithubImport be renamed to GiteaImport if doesn't make sense to rename the project creator as well?