Skip to content

Reviewer drawer: Presentation of required approver count

Proposal

Align presentation of approval count to how it is currently presented in MR list.

Doesn't make a lot of sense to have two ways of communicating the same information.

Concept

From !168428 (comment 2158420909)

Adding a progress bar to help the "Assign" button can anchor to.

CleanShot_2024-10-15_at_12.21.34

That presentation of "1 of 2" would align to how we present approvals in the MR list !148364 (merged). This presentation would still work for the proposed changes in Reviewer assignment drawer: Replace "Requires 0... (#499064 - closed) when all required approvals have been given.

Blocker: Required to be solved is how to present the scenario of optional approvals.

Edited by 🤖 GitLab Bot 🤖