Bad Feature spec performance on ee/spec/features/merge_trains/user_adds_merge_request_to_merge_train_spec.rb causing flakiness

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Summary

Bad Feature spec performance on ee/spec/features/merge_trains/user_adds_merge_request_to_merge_train_spec.rb causing flakiness.

Steps to reproduce

• Attach a binding to https://gitlab.com/gitlab-org/gitlab/-/blob/master/spec/support/capybara.rb#L200
• Run a failing spec, e.g. bundle exec rspec ee/spec/features/merge_trains/user_adds_merge_request_to_merge_train_spec.rb:112
• When the debugger is triggered, run example.exception.backtrace
• See the error coming from the example's timeout

After the failure:

• Try increasing the timeout in https://gitlab.com/gitlab-org/gitlab/-/blob/master/spec/support/helpers/wait_for_requests.rb#L43
• Re-run the spec and it will most likely pass

Possible fixes

Investigate the slow performance of the page and either open issues to improve performance or increase the timeout.