Skip to content

Refactor to use listbox-item in MR add approval rule drawer

Issue

the target branch dropdown in MR add approval rule drawer only been partially migrated. The bottom two actions seem to be using the old styles (hover background should not span the whole width of the dropdown).

Desired behaviour:

should use listbox-item instead of deprecated dropdown components.

Implementation notes:

update <gl-dropdown-item/> in ee/app/assets/javascripts/vue_shared/components/branches_selector/protected_branches_selector.vue (ref) to use <gl-listbox-item/>. refer to gitlab-ui source code for component API.

CleanShot 2025-06-26 at 11.58.07.png

Screenshot_2024-10-08_at_1.27.28_PM

Edited by 🤖 GitLab Bot 🤖